From owner-freebsd-bugs@freebsd.org Tue Dec 12 23:37:59 2017 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C3807E89388 for ; Tue, 12 Dec 2017 23:37:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id ACD6378FD8 for ; Tue, 12 Dec 2017 23:37:59 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id vBCNbxpB029626 for ; Tue, 12 Dec 2017 23:37:59 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 224300] sys/sem.h improperly declares union semun Date: Tue, 12 Dec 2017 23:37:59 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: brooks@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Dec 2017 23:37:59 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D224300 Bug ID: 224300 Summary: sys/sem.h improperly declares union semun Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Only Me Priority: --- Component: kern Assignee: freebsd-bugs@FreeBSD.org Reporter: brooks@FreeBSD.org sys/sem.h declares union semun imporpertly. According to the POSIX manpage= , it should be declared by the application if required: > The semctl() function provides a variety of semaphore control operations = as > specified by cmd. The fourth argument is optional and depends upon the > operation requested. If required, it is of type union semun, which the > application shall explicitly declare: >=20 > union semun { > int val; > struct semid_ds *buf; > unsigned short *array; > } arg; union semun is used in the kernel so the declaration should be moved under = an #ifdef _KERNEL and an exprun should be performed. It looks like configure scripts commonly handle this case so it may change code, but shouldn't break much. --=20 You are receiving this mail because: You are the assignee for the bug.=