From owner-cvs-all@FreeBSD.ORG  Thu Nov 25 10:01:26 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 70A0B16A4CE; Thu, 25 Nov 2004 10:01:26 +0000 (GMT)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 4ACE143D69; Thu, 25 Nov 2004 10:01:26 +0000 (GMT)
	(envelope-from harti@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.1/8.13.1) with ESMTP id iAPA1QHG013191;
	Thu, 25 Nov 2004 10:01:26 GMT
	(envelope-from harti@repoman.freebsd.org)
Received: (from harti@localhost)
	by repoman.freebsd.org (8.13.1/8.13.1/Submit) id iAPA1Qd6013190;
	Thu, 25 Nov 2004 10:01:26 GMT
	(envelope-from harti)
Message-Id: <200411251001.iAPA1Qd6013190@repoman.freebsd.org>
From: Hartmut Brandt <harti@FreeBSD.org>
Date: Thu, 25 Nov 2004 10:01:26 +0000 (UTC)
To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org,
	cvs-all@FreeBSD.org
X-FreeBSD-CVS-Branch: HEAD
Subject: cvs commit: src/usr.bin/make job.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 25 Nov 2004 10:01:26 -0000

harti       2004-11-25 10:01:26 UTC

  FreeBSD src repository

  Modified files:
    usr.bin/make         job.c 
  Log:
  Fix a very long-standing error in handling .SHELL targets: this target
  uses the brk_string function to parse the line. That function uses static
  storage for both the expanded string and the returned argv[] vector.
  The JobParseShell function simply stored away pointers into this static
  storage. On the next use of something like ${FOO:O} this storage would
  get overwritten with fatal results.
  
  This also allows us to make the shells[] array const bringing us one step
  further in making make WARNS=4 ready.
  
  Revision  Changes    Path
  1.60      +125 -46   src/usr.bin/make/job.c