From owner-svn-ports-all@freebsd.org Tue Jul 3 13:13:51 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4F1E0101BE5D for ; Tue, 3 Jul 2018 13:13:51 +0000 (UTC) (envelope-from timur@bat.ru) Received: from mail-oi0-x244.google.com (mail-oi0-x244.google.com [IPv6:2607:f8b0:4003:c06::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D004E80AFD for ; Tue, 3 Jul 2018 13:13:50 +0000 (UTC) (envelope-from timur@bat.ru) Received: by mail-oi0-x244.google.com with SMTP id 13-v6so3674838ois.1 for ; Tue, 03 Jul 2018 06:13:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bat-ru.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=xtIwl+fBVcD1sAIASuRygPRpIpk/pbHgaJYIwTEU1PQ=; b=VEY92+vsuIg7wIJuPTHlbtOU1lXQtLL4OBjPhCPKANxW2lFGqpST6GD/oGRbxctkUq GTSng0ANNSgxub0cY6V7hKjmJZyeT3wkIs3NyhwLVRtMg0XeUcoLJG4ppcUea/sTdhaI 61E1YT0cE2Y/4DVo1CeVLqY63UjEAmRMIOjQdfkImbWo3Ud+Ce+R6Z7bzSuLzRLOhY0q M9NpgwqBTY0ZT14KWdwOJbLKxuHbLLwoyS4ZNugXx/bNhL+GnLOmp651bs8ARAGSUcgC +bnAOWFMH0KRIA56ZgayWCHcmHGOO/RdduxLpzQ/UzYwYMDtuJWQU84YRf4M0fd6I10Z GOaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=xtIwl+fBVcD1sAIASuRygPRpIpk/pbHgaJYIwTEU1PQ=; b=qzEoSv8a4Af7zOP4dFMyvAyK/AD8vZYKNzcXS11pi5kU3fsv9NMxxbHjqAJaM8NN2p xkXNfK0f8o98dk5G04ZolBlFKBxNp32dNVsG0ELGGoOK1Uk3DmmF7Bs6vD6qbuTjncGS o8LsgPe1Ul5DGP0wlyjVT9xB4A9RZJBteRf5kHUk1Lrl7YA/hH3ov8mN+vMPd3zENeDk eIPEmbrpodCbRNOGS0V+mP1va9SZbS+lGqcbBEZC94WtbEWBFAOS5wu4XHHNktXOS0Ol OP/1XmhRwsn62XeNmNTnSOYSZENx69m4u/G1RjJyfDLEGOcNyOPFPjT6RJUq+lqDoJ8n CN+w== X-Gm-Message-State: APt69E0IVL4i32Q5NEbQrktpxwpda72LeMUmawErlPVvkSTDQGiYSEhf /96tKYUT39+HIsQ5rZQol3GHgiEIulgrO2KQc6KqOb/8H7Y= X-Google-Smtp-Source: AAOMgpeEGQf9ypB6zY8F//wR/Iw9MtW7RrJ+Mp6zhGus6aj15oj5W9xki4JQKh/WVxZQTbVhZZQPB/JEIkP0w6ilHWs= X-Received: by 2002:aca:5004:: with SMTP id e4-v6mr18630694oib.111.1530623630021; Tue, 03 Jul 2018 06:13:50 -0700 (PDT) MIME-Version: 1.0 Sender: timur@bat.ru Received: by 2002:a4a:7f11:0:0:0:0:0 with HTTP; Tue, 3 Jul 2018 06:13:19 -0700 (PDT) In-Reply-To: <20180703065839.2oqenluilcdzkl6d@atuin.in.mat.cc> References: <201807030329.w633ThS8056768@repo.freebsd.org> <20180703065839.2oqenluilcdzkl6d@atuin.in.mat.cc> From: "Timur I. Bakeyev" Date: Tue, 3 Jul 2018 15:13:19 +0200 X-Google-Sender-Auth: KqiFob2zSiJzHkZQDMyprPayVG8 Message-ID: Subject: Re: svn commit: r473793 - in head/devel: . cwrap nss_wrapper pam_wrapper resolv_wrapper socket_wrapper uid_wrapper To: Mathieu Arnold Cc: ports-committers@freebsd.org, svn-ports-all , svn-ports-head Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Jul 2018 13:13:51 -0000 On 3 July 2018 at 08:58, Mathieu Arnold wrote: > On Tue, Jul 03, 2018 at 03:29:43AM +0000, Timur I. Bakeyev wrote: > > Added: head/devel/nss_wrapper/Makefile > > ============================================================ > ================== > > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > > +++ head/devel/nss_wrapper/Makefile Tue Jul 3 03:29:42 2018 > (r473793) > > + > > +CMAKE_ARGS+= -DMAN_INSTALL_DIR:PATH="${PREFIX}/man" > > Why +=? > Fixed. > +OPTIONS_DEFINE= TEST > > +OPTIONS_DEFAULT= TEST > > + > > +TEST_TARGET= test > > Fun fact, TEST_TARGET may not do what you think it does. What it does > is tell the framework that the target to run when running `make test` is > test, which will probably fail if the TEST option is not enabled. What > you may have meant to set was TEST_TEST_TARGET, which sets TEST_TARGET > when the TEST option is enabled. > Fixed. > +TEST_CMAKE_BOOL= UNIT_TESTING > > +TEST_BUILD_DEPENDS+= cmocka>=1.1.1:sysutils/cmocka > > Why +=? > Fixed. > These are a lot of files, you should probably be using a pkg-plist file > instead. > I don't feel that 7(8) lines is an excessive amount of lines. I'd rather save inodes here. > Added: head/devel/pam_wrapper/Makefile > > Way too many files to be using PLIST_FILES, please use a pkg-plist file. > > Ok, this one is excessive, moved to pkg-plist. The rest are fixed in the same manner as nss_wrapper. BaT