Date: Tue, 07 Jul 2015 12:13:42 -0400 From: Kris Moore <kris@pcbsd.org> To: Adam Weinberger <adamw@adamw.org>, Kris Moore <kmoore@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r391421 - in head/sysutils: . docker docker/files Message-ID: <559BFAB6.3070107@pcbsd.org> In-Reply-To: <4EDFA23E-40C0-4B8E-B6D6-709C9B0B6A34@adamw.org> References: <201507061537.t66FbYeo022971@repo.freebsd.org> <4EDFA23E-40C0-4B8E-B6D6-709C9B0B6A34@adamw.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 07/07/2015 12:04, Adam Weinberger wrote:
> Hi Kris, I hope you don't feel like you're getting picked on for this port. But there are a few unusual/non-optimal things in the Makefile:
Oh, no problem. I appreciate the extra eyes on the files.
>> +BUILD_DEPENDS= ${LOCALBASE}/bin/go:${PORTSDIR}/lang/go \
>> + ${LOCALBASE}/bin/bash:${PORTSDIR}/shells/bash \
>> + ${LOCALBASE}/bin/git:${PORTSDIR}/devel/git \
>> + sqlite3:${PORTSDIR}/databases/sqlite3
>> +RUN_DEPENDS= ${LOCALBASE}/bin/go:${PORTSDIR}/lang/go \
>> + ${LOCALBASE}/bin/bash:${PORTSDIR}/shells/bash \
>> + sqlite3:${PORTSDIR}/databases/sqlite3
> All of those programs are in ${PATH}. There is no need for the ${LOCALBASE}/bin/ stuff.
Done!
> Also, git is not used at any point and that dependency can be safely removed, especially given that you already pass DOCKER_GITCOMMIT in env.
Thanks for catching that. I was using it at one point, but passing in
DOCKER_GITCOMMIT= removes the need for it now.
>
>> + ${INSTALL} ${WRKSRC}/bundles/latest/binary/docker ${STAGEDIR}${PREFIX}/bin/
> You want ${INSTALL_PROGRAM} here, not bare ${INSTALL}.
Done!
> # Adam
>
>
--
Kris Moore
PC-BSD Software / iXsystems
Enterprise Storage & Servers Driven By Open Source
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?559BFAB6.3070107>