From owner-freebsd-current@FreeBSD.ORG Sat Nov 14 19:24:13 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 00015106566B for ; Sat, 14 Nov 2009 19:24:12 +0000 (UTC) (envelope-from sgk@troutmask.apl.washington.edu) Received: from troutmask.apl.washington.edu (troutmask.apl.washington.edu [128.208.78.105]) by mx1.freebsd.org (Postfix) with ESMTP id D6A608FC12 for ; Sat, 14 Nov 2009 19:24:12 +0000 (UTC) Received: from troutmask.apl.washington.edu (localhost.apl.washington.edu [127.0.0.1]) by troutmask.apl.washington.edu (8.14.3/8.14.3) with ESMTP id nAEJO9Ho006421; Sat, 14 Nov 2009 11:24:09 -0800 (PST) (envelope-from sgk@troutmask.apl.washington.edu) Received: (from sgk@localhost) by troutmask.apl.washington.edu (8.14.3/8.14.3/Submit) id nAEJO850006420; Sat, 14 Nov 2009 11:24:08 -0800 (PST) (envelope-from sgk) Date: Sat, 14 Nov 2009 11:24:08 -0800 From: Steve Kargl To: Dmitry Marakasov Message-ID: <20091114192408.GA6354@troutmask.apl.washington.edu> References: <20091114054306.GB66462@hades.panopticon> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20091114054306.GB66462@hades.panopticon> User-Agent: Mutt/1.4.2.3i Cc: freebsd-current@freebsd.org Subject: Re: -Werror errors on RELENG_8_0 world X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Nov 2009 19:24:13 -0000 On Sat, Nov 14, 2009 at 08:43:06AM +0300, Dmitry Marakasov wrote: > cc -O2 -pipe -Wall -march=prescott -I/usr/src/lib/msun/ld80 -I/usr/src/lib/msun/src -I/usr/src/lib/msun/../libc/include -I/usr/src/lib/msun/../libc/i386 -std=gnu99 -fstack-protector -Wsystem-headers -Werror -Wno-pointer-sign -c /usr/src/lib/msun/src/e_atan2.c > cc1: warnings being treated as errors > /usr/src/lib/msun/src/e_atan2.c: In function 'atan2': > /usr/src/lib/msun/src/e_atan2.c:74: warning: suggest parentheses around arithmetic in operand of | > *** Error code 1 > --- > > There are some more, but it builds fine with NO_WERROR=1. > > SVN logs show that code wasn't changed for a long time, so why > weren't these detected and fixed yet, or am I missing something and > this is a some local problem? > I vote local problem. However, you failed to provide sufficient information to substantiate that vote. What is in your make.conf, rc.conf, src.conf, and environment that might affect the build process? As to why it isn't fixed yet, there's the old adage: "If it ain't broken, don't fix it." More to the point, e_tan2.c comes into FreeBSD via Sun's fdlibm, which is the basis of libm on the other *bsd projects. Any local cosmetic changes to e_tan2.c (and other fdlibm code) would make FreeBSD's code gratutiously different from the other projects. -- Steve