From owner-freebsd-net@FreeBSD.ORG Mon Jan 22 19:43:17 2007 Return-Path: X-Original-To: net@freebsd.org Delivered-To: freebsd-net@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 7E15216A40F for ; Mon, 22 Jan 2007 19:43:17 +0000 (UTC) (envelope-from andre@freebsd.org) Received: from c00l3r.networx.ch (c00l3r.networx.ch [62.48.2.2]) by mx1.freebsd.org (Postfix) with ESMTP id E737513C4A5 for ; Mon, 22 Jan 2007 19:43:16 +0000 (UTC) (envelope-from andre@freebsd.org) Received: (qmail 84481 invoked from network); 22 Jan 2007 19:23:03 -0000 Received: from c00l3r.networx.ch (HELO [127.0.0.1]) ([62.48.2.2]) (envelope-sender ) by c00l3r.networx.ch (qmail-ldap-1.03) with SMTP for ; 22 Jan 2007 19:23:03 -0000 Message-ID: <45B513D2.2060602@freebsd.org> Date: Mon, 22 Jan 2007 20:43:14 +0100 From: Andre Oppermann User-Agent: Thunderbird 1.5.0.9 (Windows/20061207) MIME-Version: 1.0 To: Julian Elischer References: <200701221546.l0MFk27m081898@wattres.watt.com> <45B50C5B.2080600@elischer.org> <45B50D87.2050208@freebsd.org> <45B512A0.5030502@elischer.org> In-Reply-To: <45B512A0.5030502@elischer.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Steve Watt , Uwe Doering , net@freebsd.org Subject: Re: Interesting TCP issue X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jan 2007 19:43:17 -0000 Julian Elischer wrote: > Andre Oppermann wrote: > >>>> http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/netinet/tcp_input.c.diff?r1=1.290&r2=1.291 >>>> >>>> } >>>> http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/netinet/tcp_syncache.c.diff?r1=1.84&r2=1.85 >>>> >>>> } >>>> http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/netinet/tcp_var.h.diff?r1=1.127&r2=1.128 >>>> >>>> } } How about the modifications in 'tcp_input.c'? Are they relevant >>>> to the } problem this thread is about? If so, assessing the >>>> correctness of an } MFC might prove to be a little harder. >>> >>> >>> >>> That's why I asked Andre to look at it but he's not responding.. >> >> He's about to re-appear @freebsd. >> > > great.. The TCP code is a bit like a house of cards.. Unless one is > up-to-date and has it all 'loaded' into one's mental cache, it is > all to easy to screw up function A by fixing code related to function B. > As I'm not 'loaded' I'm loathe to just MFC the one patch without being > sure what the other two are.. Yes, it's a bit messy and there are many side effects. I've cleaned up some parts in my local tree but it's a tedious task because it's so inter- mingled all over. > BTW Andre you might MFC to back to 5 and 4 too if you could.. Will look at it. -- Andre