From owner-cvs-all Wed Jun 26 8:25:59 2002 Delivered-To: cvs-all@freebsd.org Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by hub.freebsd.org (Postfix) with ESMTP id C8F5637B6F5; Wed, 26 Jun 2002 08:24:11 -0700 (PDT) Received: from pobrecita.freebsd.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.12.4/8.12.3) with ESMTP id g5QFO3cW030321; Wed, 26 Jun 2002 19:24:08 +0400 (MSD) (envelope-from ache@pobrecita.freebsd.ru) Received: (from ache@localhost) by pobrecita.freebsd.ru (8.12.4/8.12.3/Submit) id g5QFO0an030320; Wed, 26 Jun 2002 19:24:01 +0400 (MSD) (envelope-from ache) Date: Wed, 26 Jun 2002 19:23:58 +0400 From: "Andrey A. Chernov" To: Dag-Erling Smorgrav Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/crypto/openssh-portable session.c Message-ID: <20020626152357.GA30110@nagual.pp.ru> References: <200206261417.g5QEHTjR074759@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200206261417.g5QEHTjR074759@freefall.freebsd.org> User-Agent: Mutt/1.5.1i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Wed, Jun 26, 2002 at 07:17:28 -0700, Dag-Erling Smorgrav wrote: > des 2002/06/26 07:17:28 PDT > > Modified files: > crypto/openssh-portable session.c > Log: > Set basic environment variables before calling setusercontext(3) so that > it can override them. It becomes better, but not completely. What about this two left: TERM & PATH? About PATH: it seems that you expect that setusercontext() will set it, but setusercontext() can fail (its return code currently not checked, but was checked in our old code). It leaves code flow with no PATH. Better to set PATH before it & check its return code too. I am not sure about failure reaction, it can be fatal or just warning. About TERM: see "term" variable in login.conf(5) - sshd must not override it and follow the way login does. -- Andrey A. Chernov http://ache.pp.ru/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message