From owner-freebsd-net  Sun Feb  3 17:13:59 2002
Delivered-To: freebsd-net@freebsd.org
Received: from iguana.icir.org (iguana.icir.org [192.150.187.36])
	by hub.freebsd.org (Postfix) with ESMTP id C70A537B400
	for <freebsd-net@FreeBSD.ORG>; Sun,  3 Feb 2002 17:13:56 -0800 (PST)
Received: (from rizzo@localhost)
	by iguana.icir.org (8.11.3/8.11.3) id g141DjD77094;
	Sun, 3 Feb 2002 17:13:45 -0800 (PST)
	(envelope-from rizzo)
Date: Sun, 3 Feb 2002 17:13:45 -0800
From: Luigi Rizzo <rizzo@icir.org>
To: Mike Silbersack <silby@silby.com>
Cc: freebsd-net@FreeBSD.ORG
Subject: Re: [patch] removal of mbuf allocation failure messages from if_fxp
Message-ID: <20020203171345.A77071@iguana.icir.org>
References: <20020203190141.E11305-200000@patrocles.silby.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20020203190141.E11305-200000@patrocles.silby.com>
User-Agent: Mutt/1.3.23i
Sender: owner-freebsd-net@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-net.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-net>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-net>
X-Loop: FreeBSD.org

looks correct (apart from having to use patch -r to apply it...)

	cheers
	luigi

On Sun, Feb 03, 2002 at 07:03:20PM +0000, Mike Silbersack wrote:
> Luigi, does this patch look good?  AFAIK, the code you added should handle
> printing errors in these two cases; is that correct?
> 
> Thanks,
> 
> Mike "Silby" Silbersack

> --- if_fxp.c	Sun Feb  3 19:01:14 2002
> +++ if_fxp.c.old	Sun Feb  3 18:59:55 2002
> @@ -1836,6 +1836,8 @@
>  	if (m != NULL) {
>  		MCLGET(m, M_DONTWAIT);
>  		if ((m->m_flags & M_EXT) == 0) {
> +			device_printf(sc->dev,
> +			    "cluster allocation failed, packet dropped!\n");
>  			m_freem(m);
>  			if (oldm == NULL)
>  				return 1;
> @@ -1843,6 +1845,8 @@
>  			m->m_data = m->m_ext.ext_buf;
>  		}
>  	} else {
> +		device_printf(sc->dev,
> +		    "mbuf allocation failed, packet dropped!\n");
>  		if (oldm == NULL)
>  			return 1;
>  		m = oldm;


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-net" in the body of the message