Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 3 Feb 2002 17:13:45 -0800
From:      Luigi Rizzo <rizzo@icir.org>
To:        Mike Silbersack <silby@silby.com>
Cc:        freebsd-net@FreeBSD.ORG
Subject:   Re: [patch] removal of mbuf allocation failure messages from if_fxp
Message-ID:  <20020203171345.A77071@iguana.icir.org>
In-Reply-To: <20020203190141.E11305-200000@patrocles.silby.com>
References:  <20020203190141.E11305-200000@patrocles.silby.com>

next in thread | previous in thread | raw e-mail | index | archive | help
looks correct (apart from having to use patch -r to apply it...)

	cheers
	luigi

On Sun, Feb 03, 2002 at 07:03:20PM +0000, Mike Silbersack wrote:
> Luigi, does this patch look good?  AFAIK, the code you added should handle
> printing errors in these two cases; is that correct?
> 
> Thanks,
> 
> Mike "Silby" Silbersack

> --- if_fxp.c	Sun Feb  3 19:01:14 2002
> +++ if_fxp.c.old	Sun Feb  3 18:59:55 2002
> @@ -1836,6 +1836,8 @@
>  	if (m != NULL) {
>  		MCLGET(m, M_DONTWAIT);
>  		if ((m->m_flags & M_EXT) == 0) {
> +			device_printf(sc->dev,
> +			    "cluster allocation failed, packet dropped!\n");
>  			m_freem(m);
>  			if (oldm == NULL)
>  				return 1;
> @@ -1843,6 +1845,8 @@
>  			m->m_data = m->m_ext.ext_buf;
>  		}
>  	} else {
> +		device_printf(sc->dev,
> +		    "mbuf allocation failed, packet dropped!\n");
>  		if (oldm == NULL)
>  			return 1;
>  		m = oldm;


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-net" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020203171345.A77071>