From owner-freebsd-current Sun Apr 2 23: 9:18 2000 Delivered-To: freebsd-current@freebsd.org Received: from wyvern.cc.kogakuin.ac.jp (wyvern.cc.kogakuin.ac.jp [133.80.184.10]) by hub.freebsd.org (Postfix) with ESMTP id F0D6037B8F8 for ; Sun, 2 Apr 2000 23:09:14 -0700 (PDT) (envelope-from nyan@wyvern.cc.kogakuin.ac.jp) Received: from localhost (localhost [127.0.0.1]) by wyvern.cc.kogakuin.ac.jp (8.9.3+3.2W/3.7W/SAKURA) with ESMTP id PAA81332; Mon, 3 Apr 2000 15:09:08 +0900 (JST) To: imp@village.org Cc: current@FreeBSD.ORG Subject: Re: Please review newbus patch for amd and adv In-Reply-To: <200004030103.TAA56398@harmony.village.org> References: <20000402230532V.nyan@dd.catv.ne.jp> <200004030103.TAA56398@harmony.village.org> From: Takahashi Yoshihiro X-Mailer: Mew version 1.94.1 on Emacs 19.34 / Mule 2.3 (SUETSUMUHANA) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-Id: <20000403150908J.nyan@wyvern.cc.kogakuin.ac.jp> Date: Mon, 03 Apr 2000 15:09:08 +0900 (JST) X-Dispatcher: imput version 990905(IM130) Lines: 25 Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG In article <200004030103.TAA56398@harmony.village.org> Warner Losh writes: > In message <20000402230532V.nyan@dd.catv.ne.jp> Takahashi Yoshihiro writes: > : For adv driver: > : http://home.jp.FreeBSD.org/~nyan/patches/advansys.diff.gz > > I took a look at this change. For the most part it looks good. Thanks. > However, I have a question. Why did you move the adv_isa into the md > files file and then comment it out for pc98? I'm confused. Because, adv_isa.c is not required by PC-98, PC-98 requires only PCI frontend. Then it contains isa_dmacascade function which does not exist and is not needed for PC-98. The reason to comment out is to be clear that it is not required. If it is completely removed from files.pc98, we may guess wrong in the far future that we forgot to merge from files.i386. --- Takahashi Yoshihiro The Center for Information Science, Kogakuin Univ. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message