From owner-cvs-all Wed Apr 10 10:15:25 2002 Delivered-To: cvs-all@freebsd.org Received: from cheer.mahoroba.org (flets20-089.kamome.or.jp [218.45.20.89]) by hub.freebsd.org (Postfix) with ESMTP id BF18E37B404; Wed, 10 Apr 2002 10:15:20 -0700 (PDT) Received: from mille.mahoroba.org (IDENT:77CL2MYzN8WEBYvKXIj2XvytfLuJiep9536APg1ppf5q0F7v+zEgE+sbhcSAhit9@mille.mahoroba.org [IPv6:2001:200:301:0:202:2dff:fe0a:6bee]) (user=ume mech=CRAM-MD5 bits=0) by cheer.mahoroba.org (8.12.3/8.12.3) with ESMTP/inet6 id g3AHFHhw045786 (version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO); Thu, 11 Apr 2002 02:15:18 +0900 (JST) (envelope-from ume@mahoroba.org) Date: Thu, 11 Apr 2002 02:15:17 +0900 Message-ID: From: Hajimu UMEMOTO To: Mike Barcroft Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet in.h src/sys/netinet6 in6.h In-Reply-To: <200204101159.g3ABx2e55901@freefall.freebsd.org> References: <200204101159.g3ABx2e55901@freefall.freebsd.org> User-Agent: xcite1.38> Wanderlust/2.8.1 (Something) SEMI/1.14.3 (Ushinoya) FLIM/1.14.3 (=?ISO-8859-4?Q?Unebigory=F2mae?=) APEL/10.3 Emacs/21.2 (i386--freebsd) MULE/5.0 (=?ISO-2022-JP?B?GyRCOC1MWhsoQg==?=) X-Operating-System: FreeBSD 4.5-STABLE MIME-Version: 1.0 (generated by SEMI 1.14.3 - "Ushinoya") Content-Type: text/plain; charset=US-ASCII X-Virus-Scanned: by AMaViS-perl11-milter (http://amavis.org/) Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Hi, >>>>> On Wed, 10 Apr 2002 04:59:02 -0700 (PDT) >>>>> Mike Barcroft said: mike> mike 2002/04/10 04:59:02 PDT mike> Modified files: mike> sys/netinet in.h mike> sys/netinet6 in6.h mike> Log: mike> Unconditionalize the definition of INET_ADDRSTRLEN and mike> INET6_ADDRSTRLEN. Doing this helps expose bogus redefinitions in 3rd mike> party software. I cannot understand why this change is required. RFC2553 says: addresses, the buffer must be at least 16-octets. In order to allow applications to easily declare buffers of the proper size to store IPv4 and IPv6 addresses in string form, the following two constants are defined in : #define INET_ADDRSTRLEN 16 #define INET6_ADDRSTRLEN 46 I believe this two define shouldn't appear in application side. -- Hajimu UMEMOTO @ Internet Mutual Aid Society Yokohama, Japan ume@mahoroba.org ume@bisd.hitachi.co.jp ume@{,jp.}FreeBSD.org http://www.imasy.org/~ume/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message