From owner-cvs-all@FreeBSD.ORG  Thu Sep 11 07:17:07 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id D974516A4BF; Thu, 11 Sep 2003 07:17:07 -0700 (PDT)
Received: from pittgoth.com (14.zlnp1.xdsl.nauticom.net [209.195.149.111])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id AEFB643F85; Thu, 11 Sep 2003 07:17:06 -0700 (PDT)
	(envelope-from trhodes@FreeBSD.org)
Received: from localhost (acs-24-154-239-225.zoominternet.net
	[24.154.239.225])
	by pittgoth.com (8.12.9/8.12.9) with SMTP id h8BEH3vd031074;
	Thu, 11 Sep 2003 10:17:04 -0400 (EDT)
	(envelope-from trhodes@FreeBSD.org)
Date: Thu, 11 Sep 2003 09:34:34 -0400
From: Tom Rhodes <trhodes@FreeBSD.org>
To: Doug Barton <DougB@FreeBSD.org>
Message-Id: <20030911093434.18760596.trhodes@FreeBSD.org>
In-Reply-To: <20030911000107.B38429@12-234-22-23.pyvrag.nggov.pbz>
References: <200309102055.h8AKtA7N027631@repoman.freebsd.org>
	<20030911062400.GA83361@elvis.mu.org>
	<20030911000107.B38429@12-234-22-23.pyvrag.nggov.pbz>
X-Mailer: Sylpheed version 0.9.3claws (GTK+ 1.2.10; i386-portbld-freebsd5.1)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
cc: Maxime Henrion <mux@FreeBSD.org>
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/usr.sbin/sysinstall config.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 11 Sep 2003 14:17:08 -0000

On Thu, 11 Sep 2003 00:06:16 -0700 (PDT)
Doug Barton <DougB@freebsd.org> wrote:

> On Thu, 11 Sep 2003, Maxime Henrion wrote:
> 
> > Tom Rhodes wrote:
> > > trhodes     2003/09/10 13:55:10 PDT
> > >
> > >   FreeBSD src repository
> > >
> > >   Modified files:
> > >     usr.sbin/sysinstall  config.c
> > >   Log:
> > >   With the exim port upgrade, modify sysinstall(8):
> > >
> > >   - Add 'enable_exim="YES"' to rc.conf(5)
> > [...]
> >
> > All other rc.conf(5) options that enable services are of the form
> > <service>_enable.  Why the difference here?
> 
> Yeah, this is evil and should be changed. There is not guarantee that
> this won't totally break someday.


Quoting Simon since he already answered this:

It is actually not an issue, since it was just a typo in Tom's commit
message, not the actual code.  The actual code is :

--- src/usr.sbin/sysinstall/config.c	2003/08/03 05:55:21	1.212
+++ src/usr.sbin/sysinstall/config.c	2003/09/10 20:55:09	1.213
[CUT]
+    variable_set2("exim_enable", "YES", 1);


Is there still a problem Doug, Maxime?  I can do a forced commit,
or when I commit the change being discussed with Ceri I could make
a comment about the previous revision.

-- 
Tom Rhodes