From owner-freebsd-python@FreeBSD.ORG  Wed May 14 17:09:30 2014
Return-Path: <owner-freebsd-python@FreeBSD.ORG>
Delivered-To: python@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id B7735535
 for <python@freebsd.org>; Wed, 14 May 2014 17:09:30 +0000 (UTC)
Received: from mail-lb0-x229.google.com (mail-lb0-x229.google.com
 [IPv6:2a00:1450:4010:c04::229])
 (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 431F1244A
 for <python@freebsd.org>; Wed, 14 May 2014 17:09:30 +0000 (UTC)
Received: by mail-lb0-f169.google.com with SMTP id s7so1686017lbd.28
 for <python@freebsd.org>; Wed, 14 May 2014 10:09:28 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=from:content-type:content-transfer-encoding:subject:message-id:date
 :to:mime-version;
 bh=22mJ8tzZ5On5GnHvOUPkcEu23Q4CI+b+MIkSihrfIVo=;
 b=Jbttb6I2IKvQrHXPXoOTpygwYz0V0sX1CSnEPBbWiOdEPxLOTKjpO0sRF6hqObYkkw
 F50t7z6Rn2ke6V91wh6B4EiueiVlMU26V1mKK01C6b1r88huKJiDKlIburt5VdY5YMKJ
 CpYOuJiYSavKQf+7j9ufDz/9ngJIwNhuiK8SLGxClK2VcNk8GK94aVo5mYdQtadh560V
 Vrobty4mHXfimFkisEOCU9SaTfEi5y+OKjVnOrU1Q8WP76LtqM1tHWuHwt1elPK90HnS
 IWA/6wud5Bajg88EmJXo0KlVI+4Ic+/f28zpA95yNBvtoVNPEme3AcnfyF8gt8Xiuhop
 M5xA==
X-Received: by 10.152.205.106 with SMTP id lf10mr3381901lac.21.1400087368094; 
 Wed, 14 May 2014 10:09:28 -0700 (PDT)
Received: from [10.0.1.4] ([176.193.94.196])
 by mx.google.com with ESMTPSA id eo12sm2565905lbb.13.2014.05.14.10.09.26
 for <python@freebsd.org>
 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);
 Wed, 14 May 2014 10:09:27 -0700 (PDT)
From: Dmitry Sivachenko <trtrmitya@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: quoted-printable
Subject: Wrong python_CMD in shebangfix?
Message-Id: <0AE311F0-87F8-4376-8E24-742C6C54F564@gmail.com>
Date: Wed, 14 May 2014 21:09:25 +0400
To: python@freebsd.org
Mime-Version: 1.0 (Mac OS X Mail 7.2 \(1874\))
X-Mailer: Apple Mail (2.1874)
X-BeenThere: freebsd-python@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: FreeBSD-specific Python issues <freebsd-python.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-python>,
 <mailto:freebsd-python-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-python/>
List-Post: <mailto:freebsd-python@freebsd.org>
List-Help: <mailto:freebsd-python-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-python>,
 <mailto:freebsd-python-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 14 May 2014 17:09:30 -0000

Hello!

Imagine that I have python-2 as default version, so that =
/usr/local/bin/python points to python2.7
And I have a port which USE_PYTHON=3D3 and USES=3Dshebangfix.

It will "fix" python path as "/usr/local/bin/python" which is wrong (it =
should point to python3).

I propose the following patch:
--- shebangfix.mk.orig  2014-03-15 14:31:54.000000000 +0400
+++ shebangfix.mk       2014-05-14 21:08:37.000000000 +0400
@@ -38,7 +38,7 @@
 php_OLD_CMD?=3D  /usr/bin/php
 php_CMD?=3D      ${LOCALBASE}/bin/php
 python_OLD_CMD?=3D       /usr/bin/python
-python_CMD?=3D   ${LOCALBASE}/bin/python
+python_CMD?=3D   ${PYTHON_CMD}
 ruby_OLD_CMD?=3D /usr/bin/ruby
 ruby_CMD?=3D     ${LOCALBASE}/bin/ruby
 tcl_OLD_CMD?=3D  /usr/bin/tclsh


What do you think?=