Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 17 Dec 2020 12:58:05 +0000 (UTC)
From:      Michal Meloun <mmel@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org
Subject:   svn commit: r368715 - stable/12/sys/dev/pci
Message-ID:  <202012171258.0BHCw5WZ015037@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: mmel
Date: Thu Dec 17 12:58:05 2020
New Revision: 368715
URL: https://svnweb.freebsd.org/changeset/base/368715

Log:
  MFC r368364:
  
    DesignWare PCIe driver: Don't call bus_generic_attach() twice.
    bus_generic_attach() should be called from the attach function of the real
    implementation, not from the common init function.

Modified:
  stable/12/sys/dev/pci/pci_dw.c
Directory Properties:
  stable/12/   (props changed)

Modified: stable/12/sys/dev/pci/pci_dw.c
==============================================================================
--- stable/12/sys/dev/pci/pci_dw.c	Thu Dec 17 12:41:47 2020	(r368714)
+++ stable/12/sys/dev/pci/pci_dw.c	Thu Dec 17 12:58:05 2020	(r368715)
@@ -651,7 +651,7 @@ pci_dw_init(device_t dev)
 
 	device_add_child(dev, "pci", -1);
 
-	return (bus_generic_attach(dev));
+	return (0);
 out:
 	/* XXX Cleanup */
 	return (rv);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202012171258.0BHCw5WZ015037>