From owner-freebsd-current@FreeBSD.ORG  Fri Jul 13 08:55:11 2007
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: current@freebsd.org
Delivered-To: freebsd-current@FreeBSD.ORG
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 1D93316A407;
	Fri, 13 Jul 2007 08:55:11 +0000 (UTC)
	(envelope-from hselasky@c2i.net)
Received: from swip.net (mailfe07.swip.net [212.247.154.193])
	by mx1.freebsd.org (Postfix) with ESMTP id 4D98E13C4B3;
	Fri, 13 Jul 2007 08:55:09 +0000 (UTC)
	(envelope-from hselasky@c2i.net)
X-Cloudmark-Score: 0.000000 []
Received: from [194.248.135.20] (account mc467741@c2i.net HELO laptop.lan)
	by mailfe07.swip.net (CommuniGate Pro SMTP 5.1.10)
	with ESMTPA id 546198060; Fri, 13 Jul 2007 10:55:08 +0200
From: Hans Petter Selasky <hselasky@c2i.net>
To: freebsd-current@freebsd.org,
 attilio@freebsd.org
Date: Fri, 13 Jul 2007 10:55:12 +0200
User-Agent: KMail/1.9.5
References: <46970DF7.3000803@elischer.org>
	<200707131021.59966.hselasky@c2i.net>
	<46973708.2040401@FreeBSD.org>
In-Reply-To: <46973708.2040401@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200707131055.12084.hselasky@c2i.net>
Cc: Julian Elischer <julian@elischer.org>,
	FreeBSD Current <current@freebsd.org>
Subject: Re: crash in tty code in 6.1.. fixed since?
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 13 Jul 2007 08:55:11 -0000

On Friday 13 July 2007 10:25, Attilio Rao wrote:
> Hans Petter Selasky wrote:
> > If TTY was not Giant locked, you would have had an error there if another
> > mutex was locked, and the problem would have been solved years ago :-)
>
> Not sure what you mean, but the first evidence is that you would have
> explicitly drop/pickup the mutex so that you would have handled the race
>   not trasparently as Giant does.
> Moreover, it seems that tty should be partially locked with a sleeping
> primitive (sx probabilly).
>

If you lock a mutex first and then a sx-lock, you should get a warning, right?

--HPS