Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 7 Mar 2016 10:37:54 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        Wen Heping <wen@FreeBSD.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r410453 - in head/math/fityk: . files
Message-ID:  <20160307103754.GA45158@FreeBSD.org>
In-Reply-To: <201603061053.u26Arwc9042914@repo.freebsd.org>
References:  <201603061053.u26Arwc9042914@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Mar 06, 2016 at 10:53:58AM +0000, Wen Heping wrote:
> New Revision: 410453
> URL: https://svnweb.freebsd.org/changeset/ports/410453
> 
> Log:
>   - Update to 1.3.0
>   
>   PR:		205894
>   Submitted by:	tkato432@yahoo.com
> 
> [...]
>  post-install:
> -	${INSTALL_MAN} ${WRKSRC}/doc/fityk.1 ${STAGEDIR}${MANPREFIX}/man/man1
> -	${INSTALL_PROGRAM} ${WRKDIR}/${XYLIB_DISTNAME}/xyconv ${STAGEDIR}${PREFIX}/bin
> -	${INSTALL_MAN} ${WRKDIR}/${XYLIB_DISTNAME}/xyconv.1 ${STAGEDIR}${MANPREFIX}/man/man1
> +	(cd ${WRKDIR}/xylib-1.4 && ${INSTALL_PROGRAM} xyconv \
> +		${STAGEDIR}${PREFIX}/bin)
> +	(cd ${WRKDIR}/xylib-1.4 && ${INSTALL_MAN} xyconv.1 \
> +		${STAGEDIR}${MANPREFIX}/man/man1)
>  
>  post-install-DOCS-on:
>  	@${MKDIR} ${STAGEDIR}${DOCSDIR}
> -	(cd ${WRKSRC}/doc && ${COPYTREE_SHARE} html ${STAGEDIR}${DOCSDIR})
> +	@(cd ${WRKSRC}/doc && ${COPYTREE_SHARE} html \
> +		${STAGEDIR}${DOCSDIR})

What's the point of these changes?  They not just gratuitous, break "svn
blame" and increase line count for no reason, the last onw is actually wrong
as we do not mute installation commands.

Please bear in mind that Kato's patches often contain bogus changes that
should be stripped prior to committing, thank you.

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20160307103754.GA45158>