From owner-svn-src-head@FreeBSD.ORG  Sun Jan  4 20:43:26 2009
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 45D181065677;
	Sun,  4 Jan 2009 20:43:26 +0000 (UTC)
	(envelope-from kris@FreeBSD.org)
Received: from dhcp-172-28-76-114.eur.corp.google.com (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id E31698FC1B;
	Sun,  4 Jan 2009 20:43:24 +0000 (UTC)
	(envelope-from kris@FreeBSD.org)
Message-ID: <49611F6B.10802@FreeBSD.org>
Date: Sun, 04 Jan 2009 20:43:23 +0000
From: Kris Kennaway <kris@FreeBSD.org>
User-Agent: Thunderbird 2.0.0.19 (Macintosh/20081209)
MIME-Version: 1.0
To: obrien@freebsd.org
References: <200812192020.mBJKKEIo081792@svn.freebsd.org>
	<e71790db0812210415s34231791w180e33d358142b4f@mail.gmail.com>
	<20081223182314.GC25145@dragon.NUXI.org>
In-Reply-To: <20081223182314.GC25145@dragon.NUXI.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: "Carlos A. M. dos Santos" <unixmania@gmail.com>, svn-src-head@freebsd.org,
	svn-src-all@freebsd.org, src-committers@freebsd.org
Subject: Re: svn commit: r186337 - head/usr.sbin/burncd
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 04 Jan 2009 20:43:26 -0000

David O'Brien wrote:
> On Sun, Dec 21, 2008 at 10:15:21AM -0200, Carlos A. M. dos Santos wrote:
>> On Fri, Dec 19, 2008 at 6:20 PM, David E. O'Brien <obrien@freebsd.org> wrote:
>>> Author: obrien
>>> Date: Fri Dec 19 20:20:14 2008
>>> New Revision: 186337
>>> URL: http://svn.freebsd.org/changeset/base/186337
>>>
>>> Log:
>>>  burncd(8) doesn't handle signals and interrupting burncd during operation.
>>>  For example, ^C (SIGINT) may leave the drive spinning and locked.
>>>  This may also happen if you try to write a too-large image to a disc
>>>  and burncd(8) exits with an I/O error.
>>>
>>>  Add signal handling by doing a CDRIOCFLUSH ioctl to attempt to leave
>>>  burner in a sane state when burning is interrupted with SIGHUP, SIGINT,
>>>  SIGTERM, or in case an I/O error occurs during write.
>>>  Note, that blanking will still continue after interrupt but it seems to
>>>  finish correctly even after burncd(8) has quit.
>>>
>>>  Also, while I'm here bump WARNS to "6".
>>>
>>>  PR:           48730
>>>  Submitted by: Jaakko Heinonen <jh@saunalahti.fi>
>> While you are here, would you mind taking a look at bin/123693, either
>> committing the proposed patch or closing the PR if my proposition is
>> not acceptable?
> 
> Yep, I already have that patch to look at.  Note it was hell getting the
> patch - its best to not attach it when it will be base64 encoded - we
> have no easy way of extracting such encoded attachements.
>  

AFAIK, the web PR interface will detect base64-encoded attachments and 
present them for download.

Kris