From owner-svn-src-stable@freebsd.org Mon Feb 13 19:27:52 2017 Return-Path: Delivered-To: svn-src-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id AFF37CDDBC3; Mon, 13 Feb 2017 19:27:52 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-qk0-x244.google.com (mail-qk0-x244.google.com [IPv6:2607:f8b0:400d:c09::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6C9D9DEB; Mon, 13 Feb 2017 19:27:52 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-qk0-x244.google.com with SMTP id e1so16333798qkh.1; Mon, 13 Feb 2017 11:27:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=WIL88ibV6n+GPJj2AVdVemh6ttknSuyItS95uF8icX8=; b=ndOvkhNfH//duaXnAyHHSM3/XczS6yVP36HBUmxXhNIdo+t5NzmbDD8a+jFKJWXm6P aTyK6zI/SQcmW7lw+e1R7n2E+JzFj/oNCHUhIUWw1YGLt8HFrRRotdNMAD3kHn5qZ0RG BAS5l+0a4rQIIMet5qWdJx8YE5iMsIZ18gwukEdd1aEAiq/DJGFCcSak4wpFKj2qDS2/ HVoXCno5mJDbdi9lcSanAqgnoZo/akaO9+eY0hjQQnssmb+CQVPU9CfIpF8i4L41r5Cr f1hBj3jEIXMLaNnenrtLOpBUQNERxjVWSr2/kDS+HyGt67kvHw2M/pado8mgujhce7VZ EAlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=WIL88ibV6n+GPJj2AVdVemh6ttknSuyItS95uF8icX8=; b=o6SS7sQBwpRIrUehhm4YA8e5vN07M0m2xSNqnQiRHG7E3LoAXkk76auw1cJlCVrdkV WMa3ShsSeJ80wQeUhjI5ZPk2DMl77N2iGfLbttv2rsJmVKIyA84hMPFa1F0fvxk5DN9P PZp8m6ZL+wUYN2zRxehu9JSftT8ikW6gkvdzYAlanl/5G3aDEN4naByfTEwEXXEA6Iyz 6Tw6ulu9Jg+4E3AB+dhYWGGVcNFTML8DWMZKQBzoA9yA20ndxAb3J4ceYe5skGYH7VW0 6bL1C3+ox8eDIlhKCQDzFfMUFvpMOpv0S1Inq5rxvSYHRWtjBuzVb7jnoC7Ay3YYrd9R zgwg== X-Gm-Message-State: AMke39naH51XRQHbC2emgurjEeRbcd4C3YHkDGTDF5+oXXAauy+5nRBBC8KTKrvdp6EyIYp1FGVDivd0pEKLhA== X-Received: by 10.55.22.74 with SMTP id g71mr7724032qkh.40.1487014071600; Mon, 13 Feb 2017 11:27:51 -0800 (PST) MIME-Version: 1.0 Received: by 10.140.84.230 with HTTP; Mon, 13 Feb 2017 11:27:51 -0800 (PST) In-Reply-To: References: <201702110735.v1B7ZROH028648@repo.freebsd.org> From: Ngie Cooper Date: Mon, 13 Feb 2017 11:27:51 -0800 Message-ID: Subject: Re: svn commit: r313632 - in stable/10/contrib/netbsd-tests/lib/libc/gen: . posix_spawn To: Ed Schouten Cc: src-committers , "svn-src-all@freebsd.org" , "svn-src-stable@freebsd.org" , "svn-src-stable-10@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Feb 2017 19:27:52 -0000 On Sat, Feb 11, 2017 at 1:12 AM, Ed Schouten wrote: > 2017-02-11 8:35 GMT+01:00 Ngie Cooper : >> Note that sys/types.h is required on FreeBSD for kqueue(2), unlike NetBSD > > Which is a bug on its own in my opinion. What do you think of this patch? I don't mind the intent of your proposed change.. it's just that it's documented as necessary already in the manpage... so *meh*. I've hacked around this in libnetbsd, so I'm not sure if it makes sense to deviate from previous behavior. I was just backporting this change because it diff reduces with what I introduced later. Thanks! -Ngie