From owner-freebsd-bugs@FreeBSD.ORG Sat Jun 21 22:10:39 2008 Return-Path: Delivered-To: freebsd-bugs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5E94B1065670 for ; Sat, 21 Jun 2008 22:10:38 +0000 (UTC) (envelope-from yanefbsd@gmail.com) Received: from fg-out-1718.google.com (fg-out-1718.google.com [72.14.220.158]) by mx1.freebsd.org (Postfix) with ESMTP id B033C8FC17 for ; Sat, 21 Jun 2008 22:10:36 +0000 (UTC) (envelope-from yanefbsd@gmail.com) Received: by fg-out-1718.google.com with SMTP id l26so1024161fgb.35 for ; Sat, 21 Jun 2008 15:10:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from:to :subject:cc:in-reply-to:mime-version:content-type :content-transfer-encoding:content-disposition:references; bh=pfihPmkXhN5iERZ24GZFbvA15outhPq1p+TjjrUcom4=; b=gxJfmY9wTbdlMolGrX2FeeKspXMqfYMO9zcHu5v5d37COt+c8gBOsQE7Cqjr3LvVSN d4JSqZ/U1Es1KpRBjinHce/dreSt4LrwwHc6BXNtvS49SCPUN4TKOwtozTorymT4hrpx bKYiRNrRQeOszohaczJ7QmHr2zwtRns7aeheE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=ek0Nu2qocWhD/wbTZ4WAxrSUi6edUndqzOZ7rw/hMyrQEvz6eAqunG1qzj+ukstM7D Z4v0MaT4R63W1oewm6+BBTfFMi6hXQUzRQJK3ZgfwoM5AsrJS+U1T3BtKYMqdC6RnWb4 XdKfuridAGdTk1BhMmhdY02SEn+06cAH6NT7U= Received: by 10.86.4.2 with SMTP id 2mr6045716fgd.16.1214086234434; Sat, 21 Jun 2008 15:10:34 -0700 (PDT) Received: by 10.86.51.1 with HTTP; Sat, 21 Jun 2008 15:10:34 -0700 (PDT) Message-ID: <7d6fde3d0806211510t4ddd4eacxd064b34225efdca8@mail.gmail.com> Date: Sat, 21 Jun 2008 15:10:34 -0700 From: "Garrett Cooper" To: "Garrett Cooper" In-Reply-To: <200806212030.m5LKU7gG033911@freefall.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200806212030.m5LKU7gG033911@freefall.freebsd.org> Cc: freebsd-bugs@freebsd.org Subject: Re: bin/45529: [patch] hexdump(1) core-dumps with certain args X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Jun 2008 22:10:39 -0000 On Sat, Jun 21, 2008 at 1:30 PM, Garrett Cooper wrote: > The following reply was made to PR bin/45529; it has been noted by GNATS. > > From: "Garrett Cooper" > To: bug-followup@FreeBSD.org, drj@pobox.com > Cc: > Subject: Re: bin/45529: [patch] hexdump(1) core-dumps with certain args > Date: Sat, 21 Jun 2008 13:23:03 -0700 > > This patch fixes the issue (at least from what I can tell): > http://yanegomi-fbsd-patches.googlecode.com/files/hexdump_parse_fix_draft1.patch > > I also fixed the regression script: > http://yanegomi-fbsd-patches.googlecode.com/files/hexdump_regr.sh > > Cheers, > -Garrett > > Proof: > > [gcooper@optimus /devel/ncvs/src/usr.bin/hexdump]$ > /devel/hexdump_regr.sh hexdump > hexdump -e "%," > hexdump: "%,": bad format > hexdump -e "/1 "%03"," > hexdump: "/1 "%03",": bad format > hexdump -e "/1 "\%o"," > hexdump: "/1 "\%o",": bad format > hexdump -e "/1 "\t%03o"," > hexdump: "/1 "\t%03o",": bad format > hexdump -e "/1 "\\%03o"," > hexdump: "/1 "\\%03o",": bad format > hexdump -e "2/1 """ > Segmentation fault (core dumped) > [gcooper@optimus /devel/ncvs/src/usr.bin/hexdump]$ > /devel/hexdump_regr.sh ./hexdump > ./hexdump -e "%," > hexdump: "%,": bad format > ./hexdump -e "/1 "%03"," > hexdump: "/1 "%03",": bad format > ./hexdump -e "/1 "\%o"," > hexdump: "/1 "\%o",": bad format > ./hexdump -e "/1 "\t%03o"," > hexdump: "/1 "\t%03o",": bad format > ./hexdump -e "/1 "\\%03o"," > hexdump: "/1 "\\%03o",": bad format > ./hexdump -e "2/1 """ > hexdump: "2/1 """: bad format Patch doesn't fix everything. Still working on a proper patch. -Garrett