From owner-freebsd-net@FreeBSD.ORG Tue Mar 9 01:13:25 2010 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 56DEC106566B; Tue, 9 Mar 2010 01:13:25 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from tarsier.geekcn.org (tarsier.geekcn.org [211.166.10.233]) by mx1.freebsd.org (Postfix) with ESMTP id 9E3DE8FC0A; Tue, 9 Mar 2010 01:13:24 +0000 (UTC) Received: from mail.geekcn.org (tarsier.geekcn.org [211.166.10.233]) by tarsier.geekcn.org (Postfix) with ESMTP id 2B5AEA5F130; Tue, 9 Mar 2010 08:55:27 +0800 (CST) X-Virus-Scanned: amavisd-new at geekcn.org Received: from tarsier.geekcn.org ([211.166.10.233]) by mail.geekcn.org (mail.geekcn.org [211.166.10.233]) (amavisd-new, port 10024) with LMTP id oG5DbyEWcRwM; Tue, 9 Mar 2010 08:55:21 +0800 (CST) Received: from delta.delphij.net (drawbridge.ixsystems.com [206.40.55.65]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by tarsier.geekcn.org (Postfix) with ESMTPSA id F3D56A56B93; Tue, 9 Mar 2010 08:55:18 +0800 (CST) DomainKey-Signature: a=rsa-sha1; s=default; d=delphij.net; c=nofws; q=dns; h=message-id:date:from:reply-to:organization:user-agent: mime-version:to:cc:subject:references:in-reply-to: x-enigmail-version:openpgp:content-type:content-transfer-encoding; b=S+3CqYGm+WKxJNk0ap8V/aPpeCEq/dj93/ZbmBbT74fZmjE23CypsLfxVebNZsVLV eSt49v1CxoKJS89Zexv8Q== Message-ID: <4B959C72.5000002@delphij.net> Date: Mon, 08 Mar 2010 16:55:14 -0800 From: Xin LI Organization: The Geek China Organization User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.1.8) Gecko/20100304 Thunderbird/3.0.3 ThunderBrowse/3.2.8.1 MIME-Version: 1.0 To: David Horn References: <4B954C19.9050606@delphij.net> <20100308193246.GB38183@citylink.fud.org.nz> <25ff90d61003081203w48829572v37709d866eaae165@mail.gmail.com> In-Reply-To: <25ff90d61003081203w48829572v37709d866eaae165@mail.gmail.com> X-Enigmail-Version: 1.0.1 OpenPGP: id=3FCA37C1; url=http://www.delphij.net/delphij.asc Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-net@freebsd.org, d@delphij.net, Andrew Thompson Subject: Re: Why lagg(4) wants ~IFF_DRV_OACTIVE? X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: d@delphij.net List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Mar 2010 01:13:25 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hi, David, On 2010/03/08 12:03, David Horn wrote: > On Mon, Mar 8, 2010 at 2:32 PM, Andrew Thompson wrote: >> On Mon, Mar 08, 2010 at 11:12:25AM -0800, Xin LI wrote: >>> -----BEGIN PGP SIGNED MESSAGE----- >>> Hash: SHA1 >>> >>> Hi, >>> >>> Maybe this is a stupid question but I really don't understand why a >>> interface with IFF_DRV_OACTIVE can't be added to a lagg(4) interface. >>> Looking at OpenBSD code, they do this since the day 0. >>> >>> Could anyone shed some light, why we need to enforce this check? :) >> >> I think it was just carried over, I dont see any reason to keep it. > > That's good news. > > Someone, please review and commit attached patch for > sys/net/if_lagg.c. This also fixes my PR: kern/139117. This is exactly the patch I'm talking about so I committed against - -HEAD. Will MFC after 1 month so we can see if there would be some concerns or objections from others. For kern/139117, this change MAY have made the problem to disappear but I'm not convinced that the real bug has been fixed, though... Cheers, - -- Xin LI http://www.delphij.net/ FreeBSD - The Power to Serve! Live free or die -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iQEcBAEBAgAGBQJLlZxyAAoJEATO+BI/yjfB86wH/ixeSSUoIXRmja8Ujzwg9Xdw 0qeaGQZIVtYfpnVHUZ/oQ52fo9OoingogKruT8iN8oVECht90Jac5+O6xQoS1CPr G/smeZJqG/n17WTshe7Oid/D8LfiABsA+drfY57gDx4YPrKX3NRApRwRFjLcRO97 S0K7XJpItDyQ8YZVxwVJa0B3R3kC6tGxCaQ8YL4VWYa/sHrgxbmeo7RWgLUJ51oP H4NVNllk3grjln2Kv0DJHhvAkVfQocHFCJvQJ8sNGSdLjfVqr//RBHY0QhfviyfQ McfiGkA9QAG8A09wWjUTF+8dEs5jzCk0CdUhbEEhRFByuBskwAeyX+Ak0BYflLw= =oTzy -----END PGP SIGNATURE-----