From owner-svn-src-stable-10@FreeBSD.ORG Wed Sep 17 16:16:37 2014 Return-Path: Delivered-To: svn-src-stable-10@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id CCDEB1F0 for ; Wed, 17 Sep 2014 16:16:37 +0000 (UTC) Received: from mail-lb0-f171.google.com (mail-lb0-f171.google.com [209.85.217.171]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5081A286 for ; Wed, 17 Sep 2014 16:16:36 +0000 (UTC) Received: by mail-lb0-f171.google.com with SMTP id l4so901629lbv.30 for ; Wed, 17 Sep 2014 09:16:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=S3jgoj1n6OHmc1kiJi9FmvlC2MJaKSZmz48q9lQZ5N4=; b=MO6woxABjP3JrmRUTUGZHHDOIR4zdIpke/XIOwjRzWdA+/VdlSqWiFGOnMvq1SrBjt uURAolSp70DIqaN8qMP/FWgi7p0VWr0KgdKFx9wJbLB/hBcvhGRhRBp3tkblBktXq/Nq 9jn2RwsTEukGTCCkxP08yViVYMoXClQBCXpfq9ehi2tSEizO2nR97hRl1iW+T3NdQLuT jM40jjxjXTftYPYLBLi85k53Ughq1L2kjTy5X4kqD6Zs6bmc/6Cc2n5mTJny2lEBg4uG XPs2bHHEp7lXlqEUjh0SJlJaecSzVu+efye+VvVsCRprinqSNWVLw1nJ4i3GfNc3/tGY zz0w== X-Gm-Message-State: ALoCoQkljBrR3ZDuoLJV8fE98QT8nZxzM0eGirY1hcgkKRR38gm81XWHcXV2ItgTdWwtVeozYYxI X-Received: by 10.152.4.194 with SMTP id m2mr32031214lam.63.1410970594908; Wed, 17 Sep 2014 09:16:34 -0700 (PDT) Received: from [192.168.1.2] ([89.169.173.68]) by mx.google.com with ESMTPSA id t1sm6067118laz.28.2014.09.17.09.16.33 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 17 Sep 2014 09:16:34 -0700 (PDT) Message-ID: <5419B3E1.1090703@freebsd.org> Date: Wed, 17 Sep 2014 20:16:33 +0400 From: Andrey Chernov User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.1.1 MIME-Version: 1.0 To: Alexander Motin , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-10@freebsd.org Subject: Re: svn commit: r271707 - stable/10/sys/kern References: <201409171406.s8HE6LNu071461@svn.freebsd.org> In-Reply-To: <201409171406.s8HE6LNu071461@svn.freebsd.org> Content-Type: text/plain; charset=koi8-r Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-stable-10@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for only the 10-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Sep 2014 16:16:37 -0000 On 17.09.2014 18:06, Alexander Motin wrote: > + /* > + * Make sure that tdq_load updated before calling this function > + * is globally visible before we read tdq_cpu_idle. Idle thread > + * accesses both of them without locks, and the order is important. > + */ > + mb(); > + > if (TD_IS_IDLETHREAD(ctd)) { I don't understand this comment's first phrase with two verbs. Copy & paste result? I also don't see tdq_load access in this function. -- http://ache.vniz.net/