From owner-freebsd-current@FreeBSD.ORG Thu Jun 4 12:35:20 2009 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id EFA101065670; Thu, 4 Jun 2009 12:35:20 +0000 (UTC) (envelope-from decado@gmail.com) Received: from mail-pz0-f195.google.com (mail-pz0-f195.google.com [209.85.222.195]) by mx1.freebsd.org (Postfix) with ESMTP id ACE678FC21; Thu, 4 Jun 2009 12:35:20 +0000 (UTC) (envelope-from decado@gmail.com) Received: by pzk33 with SMTP id 33so702066pzk.3 for ; Thu, 04 Jun 2009 05:35:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=zj0jaXxzAXE40JxhipOrguixLiUJRsUfoXqM2LIZuIU=; b=Vgb9vLK7OxhQXAi9cMUhDsLyABNZlDIzeRNxRv2cmj9wHgzYwO8PeVKOFCKiHrRmuM BH6cQ2pUScaNOxMHKdznkqA3xrwomFMGop5jJlG0+xsyVzrOSh7dZxU9AqHJfUfAb/Pd KMcWk8wkZx1bWmitcXlFY6/ieyDyWZ6o6wN48= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=df/GkqGMDrNBDrY51FNUSzTYm5OY7lEcCkh4ejwMGGHWZOZf8HMfIH2xF5hNuWzq2z XOVNwHs1FDrlAmvHdvbAOQ/keo6qOjZufPc6wNK+5/kDI8PnS1hfVrR3fDefxyPvX/Iw Aa9Qll0V01NWq+PjmIqVTcCWYRuAqMScrNvjg= Received: by 10.114.46.6 with SMTP id t6mr2393874wat.25.1244118920258; Thu, 04 Jun 2009 05:35:20 -0700 (PDT) Received: from ?192.168.1.200? (ppp118-208-211-160.lns10.mel6.internode.on.net [118.208.211.160]) by mx.google.com with ESMTPS id k37sm2562725waf.42.2009.06.04.05.35.16 (version=TLSv1/SSLv3 cipher=RC4-MD5); Thu, 04 Jun 2009 05:35:19 -0700 (PDT) Message-ID: <4A27BF71.4030807@gmail.com> Date: Thu, 04 Jun 2009 22:34:57 +1000 From: "Andrew D. Boyd" User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) MIME-Version: 1.0 To: Dmitry Morozovsky References: <4A23D5A4.6020009@icyb.net.ua> <4A23F4B8.7000002@freebsd.org> <4A240331.1000803@FreeBSD.org> <20090602141231.67987dnz529yuqgw@webmail.leidinger.net> <4A255F8E.70604@FreeBSD.org> <4A27B51B.8090504@gmail.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Alexander Leidinger , Doug Barton , Andriy Gapon , freebsd-current@freebsd.org Subject: Re: fsck_y_enable: use -C X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Jun 2009 12:35:21 -0000 Ah my mistake. Probably best to go with what your patch. I'm thinking it is intentional so that the man page matches up with the usage. This patch would be helpful for me thanks for your work. Dmitry Morozovsky wrote: > On Thu, 4 Jun 2009, Andrew D. Boyd wrote: > > ADB> If you have a look at -F flag case in fsck_msdosfs/main.c it does not > ADB> display -F in usage() nor in the man page. > > Well, man page *do* have a reference to -F option, though not in synopsis. > I'm not sure was it intentional or not. > > ADB> > ADB> Perhaps following that might be the way to go? > ADB> > ADB> Dmitry Morozovsky wrote: > ADB> > On Tue, 2 Jun 2009, Doug Barton wrote: > ADB> > > ADB> > DB> Alexander Leidinger wrote: > ADB> > DB> > What about _flags and also adding a NOP for -C in fsck_msdosfs? > ADB> > DB> > ADB> > DB> Sounds great, I look forward to reviewing your patch. :) > ADB> > > ADB> > What do you think about attached one? >