From owner-p4-projects  Thu Jul 18 11:59: 2 2002
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 4BB8637B401; Thu, 18 Jul 2002 11:58:56 -0700 (PDT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id E48E437B400
	for <perforce@freebsd.org>; Thu, 18 Jul 2002 11:58:55 -0700 (PDT)
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 9391443E65
	for <perforce@freebsd.org>; Thu, 18 Jul 2002 11:58:55 -0700 (PDT)
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: from freefall.freebsd.org (perforce@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.4/8.12.4) with ESMTP id g6IIwtJU043613
	for <perforce@freebsd.org>; Thu, 18 Jul 2002 11:58:55 -0700 (PDT)
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: (from perforce@localhost)
	by freefall.freebsd.org (8.12.4/8.12.4/Submit) id g6IIwtYN043610
	for perforce@freebsd.org; Thu, 18 Jul 2002 11:58:55 -0700 (PDT)
Date: Thu, 18 Jul 2002 11:58:55 -0700 (PDT)
Message-Id: <200207181858.g6IIwtYN043610@freefall.freebsd.org>
X-Authentication-Warning: freefall.freebsd.org: perforce set sender to bb+lists.freebsd.perforce@cyrus.watson.org using -f
From: Robert Watson <rwatson@FreeBSD.org>
Subject: PERFORCE change 14436 for review
To: Perforce Change Reviews <perforce@freebsd.org>
Sender: owner-p4-projects@FreeBSD.ORG
Precedence: bulk
List-ID: <p4-projects.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20p4-projects>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20p4-projects>
X-Loop: FreeBSD.ORG

http://people.freebsd.org/~peter/p4db/chv.cgi?CH=14436

Change 14436 by rwatson@rwatson_tislabs on 2002/07/18 11:58:07

	A couple of comments indicating where work needs to be done to
	get EA support working for multiple policies, and pointing out
	some potential concerns to watch out for in the implementation.

Affected files ...

.. //depot/projects/trustedbsd/mac/sys/kern/kern_mac.c#169 edit

Differences ...

==== //depot/projects/trustedbsd/mac/sys/kern/kern_mac.c#169 (text+ko) ====

@@ -1077,6 +1077,12 @@
 		 * of disk, etc).
 		 */
 		mac_create_vnode_from_vnode(cred, dvp, tvp);
+
+		/*
+		 * XXX: Eventually call out to EA creation entry point
+		 * here.
+		 */
+
 		error = mac_externalize(&tvp->v_label, &extmac);
 		if (error)
 			return (error);
@@ -2340,6 +2346,13 @@
 
 	ASSERT_VOP_LOCKED(vp, "vop_stdsetlabel_ea");
 
+	/*
+	 * XXX: Eventually call out to EA check/set calls here.
+	 * Be particularly careful to avoid race conditions,
+	 * consistency problems, and stability problems when
+	 * dealing with multiple EAs.
+	 */
+
 	error = mac_externalize(intlabel, &extmac);
 	if (error)
 		return (error);

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe p4-projects" in the body of the message