Date: Thu, 18 Jul 2002 11:58:55 -0700 (PDT) From: Robert Watson <rwatson@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 14436 for review Message-ID: <200207181858.g6IIwtYN043610@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://people.freebsd.org/~peter/p4db/chv.cgi?CH=14436 Change 14436 by rwatson@rwatson_tislabs on 2002/07/18 11:58:07 A couple of comments indicating where work needs to be done to get EA support working for multiple policies, and pointing out some potential concerns to watch out for in the implementation. Affected files ... .. //depot/projects/trustedbsd/mac/sys/kern/kern_mac.c#169 edit Differences ... ==== //depot/projects/trustedbsd/mac/sys/kern/kern_mac.c#169 (text+ko) ==== @@ -1077,6 +1077,12 @@ * of disk, etc). */ mac_create_vnode_from_vnode(cred, dvp, tvp); + + /* + * XXX: Eventually call out to EA creation entry point + * here. + */ + error = mac_externalize(&tvp->v_label, &extmac); if (error) return (error); @@ -2340,6 +2346,13 @@ ASSERT_VOP_LOCKED(vp, "vop_stdsetlabel_ea"); + /* + * XXX: Eventually call out to EA check/set calls here. + * Be particularly careful to avoid race conditions, + * consistency problems, and stability problems when + * dealing with multiple EAs. + */ + error = mac_externalize(intlabel, &extmac); if (error) return (error); To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe p4-projects" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200207181858.g6IIwtYN043610>