From nobody Thu Dec 7 00:20:24 2023 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Slw083VjRz53F22; Thu, 7 Dec 2023 00:20:24 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Slw082dDZz4Kk5; Thu, 7 Dec 2023 00:20:24 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1701908424; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=wllG4PovNhpDrOA9PNK4bD7+GS9nqsIpAYK6bQuWccc=; b=Xb0ipAaQ3Z2M3gxVEH5yZOoczxgLmya06QnIYfZhr3xnKDL7rrKttQVM5RDIeUXS9COPvz 6c4HLALjVikHZUeURhOF9zKNdFBxH31omonhXhhtWtH7z/gFePSCfDfQL8oh+k/gOD5WaE rB1TQeQntgsRx2Bh+l27ZTqf7oXRTwoffvmiuk9EJwgvY29m3s+3TW9a39Pg4rpZNSZTV9 5OIblBvFfjOgMIIPrpEcGQ65kxpx7IbFHlYg5jmJF9xtA/LGF4mLYRUx+zOeZoMbWiTJaK gcKGlgTbLuRsc1FLZRfntjre2XVQALxwD+w+/pLZFviHg9AAY4N26ISTeJ03pg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1701908424; a=rsa-sha256; cv=none; b=opInJGjUgP/Soz7619ownkFRvujShwLfVJwKGIalhIVV6MNJR3WcBFdro2rRmioWQAU+AK 2HAL9HQOmJzKI1cQq75cfgwtcn09oqXFl50XfjDHtDXtMh5bWAqEy8BN/BRPrNHgH/596z O21EcMCub+t6D83idSoaFCJiXj+uwSlecEqyw4qFMedkDqxb/q1Zywl7sOJH/DjwYHmlqo BfLxVkhnn23dz5/9id1zn2VzPjeJo5av+ej9vJ2zdgNPR1P8kbjiv6ZTJe51zmNNZdQhRU xMn6GzWC+r/jexw943hOLcfBSC7hj5Rmg7phD6lEG7YpW6KEWMgE9qZCLtNPow== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1701908424; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=wllG4PovNhpDrOA9PNK4bD7+GS9nqsIpAYK6bQuWccc=; b=xVe48YGas/29LeOHcHMY2mNOj9ftr2iyjJTMJMZN4PA2toWm0mejSYGtJV/dZmB9d+jzmp mh2bJr1EgRX3wUTyR6lEnKr5uToSnHxtZW+FB6FYwe7gb95IdLRM51jiDmEevjkfQej5jV aD21Jkto4rQgenr/xmcoF/XlhyZD58ju5gkfyMzySfnoCPdv7iNsQIlvuC8DfVpAcNOVEe Jkp7ltnDN43maSXea82TDCFfNErk7ue/sATK/Y3jgqMWE0wBel1AokVhb/DpV9XzvE6a1w s4zel6OIGLqlejBJ7QLnSPJEg4ZZizoGGNmSJzmx6Mp19oMlmWpOhWDfNsXt2A== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Slw081Z9KzkV; Thu, 7 Dec 2023 00:20:24 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 3B70KOtH015829; Thu, 7 Dec 2023 00:20:24 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 3B70KOpT015826; Thu, 7 Dec 2023 00:20:24 GMT (envelope-from git) Date: Thu, 7 Dec 2023 00:20:24 GMT Message-Id: <202312070020.3B70KOpT015826@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mitchell Horne Subject: git: 165cc0eea9d1 - stable/14 - busdma: emit a warning for use of filters List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-all@freebsd.org X-BeenThere: dev-commits-src-all@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: mhorne X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: 165cc0eea9d1e35bc448e8b329ed1919fba6bcd3 Auto-Submitted: auto-generated The branch stable/14 has been updated by mhorne: URL: https://cgit.FreeBSD.org/src/commit/?id=165cc0eea9d1e35bc448e8b329ed1919fba6bcd3 commit 165cc0eea9d1e35bc448e8b329ed1919fba6bcd3 Author: Mitchell Horne AuthorDate: 2023-12-04 15:46:48 +0000 Commit: Mitchell Horne CommitDate: 2023-12-06 23:23:14 +0000 busdma: emit a warning for use of filters Filter functions are deprecated, and unused in the tree. If either of the filter or filterarg arguments to bus_dma_tag_create() are non-NULL, print a warning. This is a direct commit to stable/14. Reviewed by: jhb Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D42897 --- sys/arm/arm/busdma_machdep.c | 4 ++++ sys/arm64/arm64/busdma_machdep.c | 4 ++++ sys/powerpc/powerpc/busdma_machdep.c | 4 ++++ sys/riscv/riscv/busdma_machdep.c | 4 ++++ sys/x86/x86/busdma_machdep.c | 4 ++++ 5 files changed, 20 insertions(+) diff --git a/sys/arm/arm/busdma_machdep.c b/sys/arm/arm/busdma_machdep.c index 07a3da114441..8dd4f3bff23d 100644 --- a/sys/arm/arm/busdma_machdep.c +++ b/sys/arm/arm/busdma_machdep.c @@ -398,6 +398,10 @@ bus_dma_tag_create(bus_dma_tag_t parent, bus_size_t alignment, /* Return a NULL tag on failure */ *dmat = NULL; + /* Filters are deprecated, emit a warning. */ + if (filter != NULL || filterarg != NULL) + printf("Warning: use of filters is deprecated; see busdma(9)\n"); + newtag = (bus_dma_tag_t)malloc(sizeof(*newtag), M_BUSDMA, M_ZERO | M_NOWAIT); if (newtag == NULL) { diff --git a/sys/arm64/arm64/busdma_machdep.c b/sys/arm64/arm64/busdma_machdep.c index 14fd96ac919c..c1b710e3538d 100644 --- a/sys/arm64/arm64/busdma_machdep.c +++ b/sys/arm64/arm64/busdma_machdep.c @@ -161,6 +161,10 @@ bus_dma_tag_create(bus_dma_tag_t parent, bus_size_t alignment, struct bus_dma_tag_common *tc; int error; + /* Filters are deprecated, emit a warning. */ + if (filter != NULL || filterarg != NULL) + printf("Warning: use of filters is deprecated; see busdma(9)\n"); + if (parent == NULL) { error = bus_dma_bounce_impl.tag_create(parent, alignment, boundary, lowaddr, highaddr, filter, filterarg, maxsize, diff --git a/sys/powerpc/powerpc/busdma_machdep.c b/sys/powerpc/powerpc/busdma_machdep.c index bffbfa94acac..873a67458dfc 100644 --- a/sys/powerpc/powerpc/busdma_machdep.c +++ b/sys/powerpc/powerpc/busdma_machdep.c @@ -168,6 +168,10 @@ bus_dma_tag_create(bus_dma_tag_t parent, bus_size_t alignment, return (EINVAL); } + /* Filters are deprecated, emit a warning. */ + if (filter != NULL || filterarg != NULL) + printf("Warning: use of filters is deprecated; see busdma(9)\n"); + /* Return a NULL tag on failure */ *dmat = NULL; diff --git a/sys/riscv/riscv/busdma_machdep.c b/sys/riscv/riscv/busdma_machdep.c index 19cfd21edc6e..e8aca33a86c0 100644 --- a/sys/riscv/riscv/busdma_machdep.c +++ b/sys/riscv/riscv/busdma_machdep.c @@ -162,6 +162,10 @@ bus_dma_tag_create(bus_dma_tag_t parent, bus_size_t alignment, struct bus_dma_tag_common *tc; int error; + /* Filters are deprecated, emit a warning. */ + if (filter != NULL || filterarg != NULL) + printf("Warning: use of filters is deprecated; see busdma(9)\n"); + if (parent == NULL) { error = bus_dma_bounce_impl.tag_create(parent, alignment, boundary, lowaddr, highaddr, filter, filterarg, maxsize, diff --git a/sys/x86/x86/busdma_machdep.c b/sys/x86/x86/busdma_machdep.c index 0e72b09684cc..ee614548aea7 100644 --- a/sys/x86/x86/busdma_machdep.c +++ b/sys/x86/x86/busdma_machdep.c @@ -184,6 +184,10 @@ bus_dma_tag_create(bus_dma_tag_t parent, bus_size_t alignment, struct bus_dma_tag_common *tc; int error; + /* Filters are deprecated, emit a warning. */ + if (filter != NULL || filterarg != NULL) + printf("Warning: use of filters is deprecated; see busdma(9)\n"); + if (parent == NULL) { error = bus_dma_bounce_impl.tag_create(parent, alignment, boundary, lowaddr, highaddr, filter, filterarg, maxsize,