From owner-svn-src-head@freebsd.org Fri Apr 24 14:29:15 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 1911A2B6F33 for ; Fri, 24 Apr 2020 14:29:15 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qv1-xf2d.google.com (mail-qv1-xf2d.google.com [IPv6:2607:f8b0:4864:20::f2d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 497xPk2KQLz4Rch for ; Fri, 24 Apr 2020 14:29:14 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-qv1-xf2d.google.com with SMTP id q2so4733645qvd.1 for ; Fri, 24 Apr 2020 07:29:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HfwlhWLl/F18kSMsFHza/H7cyGmF3NjietkOAYPmSs8=; b=ncp+jbBNs6qjY25ZXT9uAtmbOQP/TaKIVEIhrIy9J2LJDo5f5fuUTJD0kAIU6Q5jKP Cv4nldhMHMrodTwpASHtZih/sbAXdH2M9EsO0EXu4e8BHwh4HlvvDNpl/4KCKbnHDf6W K5vdoNTTqDZDSkep2sWcemp4qkMCh2AY26IBMZBuvxabHphVu70/mI6Pzi67l5yWZ1UR LxjG0TWTwMmrRmvu10Gvh11D+5tEIwvrpNyPk+gj8dKXNGUQH1IEKFj5LAGpth2bE6FA +fJNa/M18lVkSLm97bUqLN1a1ThL4Tme4YXz1pbYiC83RW6gj+TaVS8ofqo5sRGEv0Nh GRZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HfwlhWLl/F18kSMsFHza/H7cyGmF3NjietkOAYPmSs8=; b=FPv9XMpFZOKZXH0D0D9wsJEtzE83iedf78ONZtAwZyrIdvqo7kmyU5eX2ED5/1auRO nZBBP94T5rpNOEas4KWq3TaLNMUoN8+hRIG0v9j4h3W5YpOe3SEAJs1QunsVnk1jsQ36 OgD6b7APiC1sOGTT8z6TurMrQXf2WkWmqE346/5sUXM13Up8lyQtGSUAmOUQCz0VzY/O fgDRLBqW/+Y4Ph35KaXruNrwUrnvPFt1YDmiwEkXcOoelxe0bG6JB/zftfKQczZtdXHd qg00tkbnN1Q/YMiY8dDRkcr7DOptYj8Vt5hHLRrZx2xqY4njyjEWjKB4rN9QqdUU3RKr WqJw== X-Gm-Message-State: AGi0PuakBhynlEHuX8DZkBUgb7WMtYTcZ3cink4LwoiO8aJ6q2LcPXOa LNB4xu1wBTnzoP14JTl3TC67s9p6h0JZGaZWnew0sA== X-Google-Smtp-Source: APiQypIUeQNWJrF0GnEV9feeFxOGpsWkiPAFz4aClOwlRK2+FZ5VX0VowxNsSP6vfonC8A8h4ltapfGHx7RPQ3F2l98= X-Received: by 2002:a0c:f8cf:: with SMTP id h15mr9091832qvo.22.1587738553027; Fri, 24 Apr 2020 07:29:13 -0700 (PDT) MIME-Version: 1.0 References: <202004240749.03O7nMSc066344@repo.freebsd.org> In-Reply-To: <202004240749.03O7nMSc066344@repo.freebsd.org> From: Warner Losh Date: Fri, 24 Apr 2020 08:29:01 -0600 Message-ID: Subject: Re: svn commit: r360241 - head/sys/dev/ichiic To: Andriy Gapon Cc: src-committers , svn-src-all , svn-src-head X-Rspamd-Queue-Id: 497xPk2KQLz4Rch X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=bsdimp-com.20150623.gappssmtp.com header.s=20150623 header.b=ncp+jbBN; dmarc=none; spf=none (mx1.freebsd.org: domain of wlosh@bsdimp.com has no SPF policy when checking 2607:f8b0:4864:20::f2d) smtp.mailfrom=wlosh@bsdimp.com X-Spamd-Result: default: False [-2.03 / 15.00]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; R_DKIM_ALLOW(-0.20)[bsdimp-com.20150623.gappssmtp.com:s=20150623]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; PREVIOUSLY_DELIVERED(0.00)[svn-src-head@freebsd.org]; DMARC_NA(0.00)[bsdimp.com]; URI_COUNT_ODD(1.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; DKIM_TRACE(0.00)[bsdimp-com.20150623.gappssmtp.com:+]; RCVD_IN_DNSWL_NONE(0.00)[d.2.f.0.0.0.0.0.0.0.0.0.0.0.0.0.0.2.0.0.4.6.8.4.0.b.8.f.7.0.6.2.list.dnswl.org : 127.0.5.0]; R_SPF_NA(0.00)[]; FORGED_SENDER(0.30)[imp@bsdimp.com,wlosh@bsdimp.com]; MIME_TRACE(0.00)[0:+,1:+,2:~]; IP_SCORE(-1.04)[ip: (-4.37), ipnet: 2607:f8b0::/32(-0.33), asn: 15169(-0.43), country: US(-0.05)]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; FROM_NEQ_ENVFROM(0.00)[imp@bsdimp.com,wlosh@bsdimp.com]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Apr 2020 14:29:15 -0000 On Fri, Apr 24, 2020 at 1:49 AM Andriy Gapon wrote: > Author: avg > Date: Fri Apr 24 07:49:21 2020 > New Revision: 360241 > URL: https://svnweb.freebsd.org/changeset/base/360241 > > Log: > ig4: ensure that drivers always attach in correct order > > Use DRIVER_MODULE_ORDERED(SI_ORDER_ANY) so that ig4's ACPI attachment > happens after iicbus and acpi_iicbus drivers are registered. > > I have seen a problem where iicbus attached under ig4 instead of > acpi_iicbus when ig4.ko was loaded with kldload. I believe that that > happened because ig4 driver was a first driver to register, it attached > and created an iicbus child. Then iicbus driver was registered and, > since it was the only driver that could attach to the iicbus child > device, it did exactly that. After that acpi_iicbus driver was > registered. It would be able to attach to the iicbus device, but it was > already attached, so nothing happened. > Can you post more details of which devices are affected? From the description and the patch, I don't see how this could fix things. Warner > MFC after: 2 weeks > > Modified: > head/sys/dev/ichiic/ig4_acpi.c > > Modified: head/sys/dev/ichiic/ig4_acpi.c > > ============================================================================== > --- head/sys/dev/ichiic/ig4_acpi.c Fri Apr 24 05:05:58 2020 > (r360240) > +++ head/sys/dev/ichiic/ig4_acpi.c Fri Apr 24 07:49:21 2020 > (r360241) > @@ -192,5 +192,6 @@ static driver_t ig4iic_acpi_driver = { > sizeof(struct ig4iic_softc), > }; > > -DRIVER_MODULE(ig4iic, acpi, ig4iic_acpi_driver, ig4iic_devclass, 0, 0); > +DRIVER_MODULE_ORDERED(ig4iic, acpi, ig4iic_acpi_driver, ig4iic_devclass, > 0, 0, > + SI_ORDER_ANY); > MODULE_DEPEND(ig4iic, acpi, 1, 1, 1); >