Date: Wed, 12 Mar 2014 17:59:55 +0100 From: Tijl Coosemans <tijl@FreeBSD.org> To: Mathieu Arnold <mat@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r347897 - head/devel/git Message-ID: <20140312175955.7dbc48a3@kalimero.tijl.coosemans.org> In-Reply-To: <6405D0DB0BBE9214BFFFE025@ogg.in.absolight.net> References: <201403111758.s2BHwmaJ008196@svn.freebsd.org> <AE1AAB14BF419A28B0CE399B@atuin.in.mat.cc> <20140312124838.4e7fcdea@kalimero.tijl.coosemans.org> <6405D0DB0BBE9214BFFFE025@ogg.in.absolight.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 12 Mar 2014 13:39:21 +0100 Mathieu Arnold wrote: >+--On 12 mars 2014 12:48:38 +0100 Tijl Coosemans <tijl@FreeBSD.org> wrote: >| On Wed, 12 Mar 2014 11:09:02 +0100 Mathieu Arnold wrote: >|>+--On 11 mars 2014 17:58:48 +0000 Tijl Coosemans <tijl@FreeBSD.org> wrote: >|>| Author: tijl >|>| Date: Tue Mar 11 17:58:47 2014 >|>| New Revision: 347897 >|>| URL: http://svnweb.freebsd.org/changeset/ports/347897 >|>| QAT: https://qat.redports.org/buildarchive/r347897/ >|>| >|>| Log: >|>| Prevent detection of libcharset.h from converters/libiconv. >|>| >|>| This forces git to use nl_langinfo() from libc instead of >|>| locale_charset() from libiconv. (The latter is practically an alias >|>| for the first.) >|> >|> This need a PORTREVISION bump, doesn't it ? >| >| I decided not to bump it, but it is an edge case. This commit fixes >| a build error on FreeBSD 10 with libiconv installed. When libiconv >| is not installed it does not change anything. On FreeBSD 8 and 9 it >| does change git to use nl_langinfo() instead of locale_charset() but >| these functions are the same and git still links with libiconv for >| other functions. So the dependencies stay the same, pkg-plist stays >| the same and the overall functionality stays the same. > > Well, to quote the porter's handbook[1]: > > PORTREVISION should be increased each time a change is made to the port > that changes the generated package in any way. That includes changes that > only affect a package built with non-default options. > > If it's only a build fix, that is, there were no packages with the same > version before, it's ok not to bump it, but if it changes the package, any > package, it has to be bumped. > > 1: > <http://www.freebsd.org/doc/en/books/porters-handbook/makefile-naming.html#idp63577392>; Yes I know, but that rule is too simple in this case. There's no benefit to bump the version here. Git called a() which returns b() and now git calls b() directly. This makes no difference to users and it makes no difference to other ports/packages.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140312175955.7dbc48a3>