From owner-freebsd-bugs@FreeBSD.ORG Thu Jun 6 19:10:01 2013 Return-Path: Delivered-To: freebsd-bugs@smarthost.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 75DF1188 for ; Thu, 6 Jun 2013 19:10:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 67D6412CB for ; Thu, 6 Jun 2013 19:10:01 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r56JA1Tq003994 for ; Thu, 6 Jun 2013 19:10:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r56JA1vH003993; Thu, 6 Jun 2013 19:10:01 GMT (envelope-from gnats) Date: Thu, 6 Jun 2013 19:10:01 GMT Message-Id: <201306061910.r56JA1vH003993@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org Cc: From: Guy Helmer Subject: Re: bin/150988: adduser(8) problem of directory mode X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: Guy Helmer List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Jun 2013 19:10:01 -0000 The following reply was made to PR bin/150988; it has been noted by GNATS. From: Guy Helmer To: bug-followup@FreeBSD.org, zrcvic@foxmail.com Cc: Subject: Re: bin/150988: adduser(8) problem of directory mode Date: Thu, 6 Jun 2013 14:03:02 -0500 I see that jkim changed the directory creation code to use _DEF_DIRMODE = (which is defined in pw.h as S_IRWXU | S_IRWXG | S_IRWXO) in rev 219408. However, I would expect mkdir() to follow the umask value, so I would = not expect your suggested patch to result in any functional difference. = I would expect that we should instead chmod() after mkdir() to apply a = useful access mode to the directory after creation, or temporarily = change the umask before mkdir().