From owner-freebsd-wireless@FreeBSD.ORG  Tue Mar 12 02:50:08 2013
Return-Path: <owner-freebsd-wireless@FreeBSD.ORG>
Delivered-To: freebsd-wireless@freebsd.org
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id AA6A917E
 for <freebsd-wireless@freebsd.org>; Tue, 12 Mar 2013 02:50:08 +0000 (UTC)
 (envelope-from adrian.chadd@gmail.com)
Received: from mail-wg0-f44.google.com (mail-wg0-f44.google.com [74.125.82.44])
 by mx1.freebsd.org (Postfix) with ESMTP id 4470A186
 for <freebsd-wireless@freebsd.org>; Tue, 12 Mar 2013 02:50:07 +0000 (UTC)
Received: by mail-wg0-f44.google.com with SMTP id dr12so5674888wgb.35
 for <freebsd-wireless@freebsd.org>; Mon, 11 Mar 2013 19:50:07 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:x-received:sender:in-reply-to:references:date
 :x-google-sender-auth:message-id:subject:from:to:cc:content-type;
 bh=c6AE11328PreF0VrfazGZMzeor4DTyy3o74X1Rscc0Y=;
 b=oKZoNp28UiLEnBjf1HZKnbOY0oVKhOs5dThTyBzNV0qZ9iU3yFbI/zIes3nzgm4anE
 JHnWQRi2KEsXwDzzioFxN/5uEFllTL2jQjhmX2XQU7nUeHr+j/899xUU0pOovAsTdKX0
 kHnnYY8iBAMspeqesGHn0+ur97EhgSsdieGG/52x9BglKvSHiTZGAQeWEb+SE1ZAdYSy
 A6RYUceJwQdzNVEjljQOvUHeMkFRiWBRSqqN5gl4pjQvPhw8aytuwDOiCgdd8aBAEp5D
 pZR2eO2JXA1Nh3Om5l1JiG3OmuRCBKyl9INZdhZRK4abPTeFZDmxX/m24tuA2J78XVB9
 Yp+g==
MIME-Version: 1.0
X-Received: by 10.194.133.98 with SMTP id pb2mr23311150wjb.20.1363056607047;
 Mon, 11 Mar 2013 19:50:07 -0700 (PDT)
Sender: adrian.chadd@gmail.com
Received: by 10.216.111.201 with HTTP; Mon, 11 Mar 2013 19:50:06 -0700 (PDT)
In-Reply-To: <CAJ-Vmok2ONOJsZK4BuD9J5drUpmjri6mV-dB4N7-9HvuGcVV0Q@mail.gmail.com>
References: <513d3ae3.08c2440a.59a6.63b2@mx.google.com>
 <513DA767.6010208@gmail.com>
 <CAJ-Vmo=uSeKK1SV3k_nRLDSHShobiyN6ky861b5NDn_U8NxukQ@mail.gmail.com>
 <513E6AF5.9010304@gmail.com>
 <CAJ-Vmo=9Kj41=J3m6SapXi0y6t9cF-A=XCX8AWz0qirLnrwX=Q@mail.gmail.com>
 <513E7924.3060302@gmail.com>
 <CAJ-VmomWgitUZvxVQbQc6qFu8rOYJVZiZCrVEjQm2fOdp5Sz7w@mail.gmail.com>
 <CAJ-Vmok2ONOJsZK4BuD9J5drUpmjri6mV-dB4N7-9HvuGcVV0Q@mail.gmail.com>
Date: Mon, 11 Mar 2013 19:50:06 -0700
X-Google-Sender-Auth: 58gMHcagn4nJqORFXHw_JtW746E
Message-ID: <CAJ-VmonmrYV__z_6VterhZ2itmtL2seTo0VQ5oUHTOwuCWydQg@mail.gmail.com>
Subject: Re: Fine, OK, here's my initial AR9380/AR9485 support
From: Adrian Chadd <adrian@freebsd.org>
To: Joshua Isom <jrisom@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Cc: "freebsd-wireless@freebsd.org" <freebsd-wireless@freebsd.org>
X-BeenThere: freebsd-wireless@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "Discussions of 802.11 stack,
 tools device driver development." <freebsd-wireless.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-wireless>, 
 <mailto:freebsd-wireless-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-wireless>
List-Post: <mailto:freebsd-wireless@freebsd.org>
List-Help: <mailto:freebsd-wireless-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-wireless>, 
 <mailto:freebsd-wireless-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Mar 2013 02:50:08 -0000

On 11 March 2013 17:43, Adrian Chadd <adrian@freebsd.org> wrote:
> .. and yeah, that code is wrong. GCC doesn't complain; just change it to:
>
>         if ((ahp->ah_enterprise_mode && AR_ENT_OTP_MIN_PKT_SIZE_DISABLE) &&
>
> to:
>
>         if ((ahp->ah_enterprise_mode & AR_ENT_OTP_MIN_PKT_SIZE_DISABLE) &&
>
> Thanks, this is the first bug that I can file as having come from the
> FreeBSD community. :)

I'll tinker with this a bit more, but cleaning things up to keep clang
happy will take quite a bit of time.

I'm about to push an update which changes the directory that I'm
hiding this in, in (eventual) preparation for committing this to
-HEAD.

Thanks,



Adrian