From owner-freebsd-bugs@freebsd.org  Wed Jun  7 14:51:00 2017
Return-Path: <owner-freebsd-bugs@freebsd.org>
Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id BB21DC7759B
 for <freebsd-bugs@mailman.ysv.freebsd.org>;
 Wed,  7 Jun 2017 14:51:00 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id A8FAD76C17
 for <freebsd-bugs@FreeBSD.org>; Wed,  7 Jun 2017 14:51:00 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id v57Ep0BH059544
 for <freebsd-bugs@FreeBSD.org>; Wed, 7 Jun 2017 14:51:00 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-bugs@FreeBSD.org
Subject: [Bug 132302] [patch] smbutil(1): contrib/smbfs subr.c: saved
 passwords >18 char fail
Date: Wed, 07 Jun 2017 14:51:00 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: bin
X-Bugzilla-Version: unspecified
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Only Me
X-Bugzilla-Who: guru@unixarea.de
X-Bugzilla-Status: In Progress
X-Bugzilla-Resolution: 
X-Bugzilla-Priority: Normal
X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: cc
Message-ID: <bug-132302-8-xQZsWV1jq9@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-132302-8@https.bugs.freebsd.org/bugzilla/>
References: <bug-132302-8@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 07 Jun 2017 14:51:00 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D132302

Matthias Apitz <guru@unixarea.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |guru@unixarea.de

--- Comment #1 from Matthias Apitz <guru@unixarea.de> ---
I stumbled over the same old bug, debugged it and came up with this SVN dif=
f:

$ svn diff src/contrib/smbfs/lib/smb/subr.c
Index: src/contrib/smbfs/lib/smb/subr.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- src/contrib/smbfs/lib/smb/subr.c    (revisi=C3=B3n: 314251)
+++ src/contrib/smbfs/lib/smb/subr.c    (copia de trabajo)
@@ -232,6 +232,8 @@
                          islower(ch) ? ('a' + (ch - 'a' + 13) % 26) : ch);
                ch ^=3D pos;
                pos +=3D 13;
+               if (pos > 256)
+                   pos -=3D 256;
                sprintf(dst, "%02x", ch);
                dst +=3D 2;
        }
@@ -262,6 +264,8 @@
                        return EINVAL;
                ch ^=3D pos;
                pos +=3D 13;
+               if (pos > 256)
+                   pos -=3D 256;
                if (isascii(ch))
                    ch =3D (isupper(ch) ? ('A' + (ch - 'A' + 13) % 26) :
                          islower(ch) ? ('a' + (ch - 'a' + 13) % 26) : ch);

I wanted to file a PR, but found with search this older issue with nearly t=
he
same solution :-(

can someone please look into it, do a code rev and commit it; thanks

--=20
You are receiving this mail because:
You are the assignee for the bug.=