From owner-freebsd-current Thu Jan 28 00:17:45 1999 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id AAA05928 for freebsd-current-outgoing; Thu, 28 Jan 1999 00:17:45 -0800 (PST) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from relay.nuxi.com ([169.237.7.38]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id AAA05923 for ; Thu, 28 Jan 1999 00:17:44 -0800 (PST) (envelope-from obrien@NUXI.com) Received: (from obrien@localhost) by relay.nuxi.com (8.9.1/8.9.1) id AAA00894; Thu, 28 Jan 1999 00:17:43 -0800 (PST) (envelope-from obrien) Date: Thu, 28 Jan 1999 00:17:43 -0800 From: "David O'Brien" To: Matthew Dillon Cc: current@FreeBSD.ORG Subject: Re: kern/subr_scanf array index of signed char Message-ID: <19990128001743.A563@relay.nuxi.com> Reply-To: obrien@NUXI.com References: <199901280204.SAA19979@bubba.whistle.com> <199901280207.SAA88572@apollo.backplane.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.95i In-Reply-To: <199901280207.SAA88572@apollo.backplane.com>; from Matthew Dillon on Wed, Jan 27, 1999 at 06:07:18PM -0800 X-Operating-System: FreeBSD 3.0-CURRENT Organization: The NUXI BSD group X-PGP-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Keyid: 34F9F9D5 Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG > :Just curious.. why do you need the "(int)" cast? > > Actually, it could very well be that I don't. I didn't want to spend > the time to check to see if the compiler warned on unsigned-char array > indexes. When you add casts to quite warnings, please use the minium number of them. Even if it takes a little more time to test. I would much rather have the warnings than obfuscated code. -- -- David (obrien@NUXI.com -or- obrien@FreeBSD.org) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message