From owner-freebsd-office@FreeBSD.ORG  Sun Jul 31 11:04:05 2011
Return-Path: <owner-freebsd-office@FreeBSD.ORG>
Delivered-To: office@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0128C106566C
	for <office@freebsd.org>; Sun, 31 Jul 2011 11:04:05 +0000 (UTC)
	(envelope-from pali.gabor@googlemail.com)
Received: from mail-fx0-f54.google.com (mail-fx0-f54.google.com
	[209.85.161.54])
	by mx1.freebsd.org (Postfix) with ESMTP id 870EA8FC08
	for <office@freebsd.org>; Sun, 31 Jul 2011 11:04:04 +0000 (UTC)
Received: by fxe4 with SMTP id 4so5047739fxe.13
	for <office@freebsd.org>; Sun, 31 Jul 2011 04:04:03 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=googlemail.com; s=gamma;
	h=sender:message-id:date:from:organization:user-agent:mime-version:to
	:subject:references:in-reply-to:x-enigmail-version:content-type
	:content-transfer-encoding;
	bh=phr2r7wtjN2H0VJv2DLo/m8FHOqSZKjfikf5Fol11QY=;
	b=D+bStKdBPwx15eT5QW8Q8yNVtg2TH2QX1PEw6rsvYeHNvCaDXgkuXj8cK4PFKdJUUY
	oI23/Pyc7qt6QXEpMXnonuvbj7tpsRhiW15eEEqKWlb+39aEsm9DM0zsyWW9d6w0uOy3
	kVdfj/sybL3k242Pv4aZNiqfdqX53zriYBUEM=
Received: by 10.223.55.79 with SMTP id t15mr3457696fag.23.1312110242492;
	Sun, 31 Jul 2011 04:04:02 -0700 (PDT)
Received: from [192.168.1.101] (catv-80-99-199-223.catv.broadband.hu
	[80.99.199.223])
	by mx.google.com with ESMTPS id 28sm2206407fax.27.2011.07.31.04.04.02
	(version=SSLv3 cipher=OTHER); Sun, 31 Jul 2011 04:04:02 -0700 (PDT)
Sender: =?UTF-8?B?UMOBTEkgR8OhYm9yIErDoW5vcw==?= <pali.gabor@googlemail.com>
Message-ID: <4E353651.2000303@FreeBSD.org>
Date: Sun, 31 Jul 2011 13:02:41 +0200
From: Gabor PALI <pgj@FreeBSD.org>
Organization: The FreeBSD Project
User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US;
	rv:1.9.2.9) Gecko/20100925 Thunderbird/3.1.4
MIME-Version: 1.0
To: office@freebsd.org
References: <4E34D620.70404@FreeBSD.org>
	<CADLo83-LEqugpobSD8HDWia3oy-nbaMZWAB4CqCuuKa8LdOH7w@mail.gmail.com>
In-Reply-To: <CADLo83-LEqugpobSD8HDWia3oy-nbaMZWAB4CqCuuKa8LdOH7w@mail.gmail.com>
X-Enigmail-Version: 1.1.2
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: 
Subject: Re: [patch] Moving LibreOffice Version to an .mk File
X-BeenThere: freebsd-office@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Office applications on FreeBSD <freebsd-office.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-office>, 
	<mailto:freebsd-office-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-office>
List-Post: <mailto:freebsd-office@freebsd.org>
List-Help: <mailto:freebsd-office-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-office>,
	<mailto:freebsd-office-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 31 Jul 2011 11:04:05 -0000

 On 07/31/11 09:52, Chris Rees wrote:
> How about a Mk/bsd.office.mk, and then having USE_LIBREOFFICE knobs
> added to bsd.port.mk? We could share bsd.office.mk with the other
> office ports.

My intention is to only share common variables between ports (at least
for now).  In practice, adding an ".include" line is almost like adding
a "USE_LIBREOFFICE=" line :-)  Your suggested modification touches
bsd.port.mk too that might be cumbersome to commit because of the
portmgr policy.  (Though we have a Baptiste here...)

Since creating a bsd.office.mk only because of a few shared variables
would be funny so I would add the LibreOffice l10n [1] stuff also, it
may be making more sense.

[1]
https://github.com/bapt/libreoffice-ports/blob/master/editors/libreoffice-l10n/bsd.l10n.mk