Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 30 Oct 2015 17:12:15 +0000 (UTC)
From:      "Simon J. Gerraty" <sjg@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r290201 - head/sys/dev/xen/netfront
Message-ID:  <201510301712.t9UHCFPd096813@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: sjg
Date: Fri Oct 30 17:12:15 2015
New Revision: 290201
URL: https://svnweb.freebsd.org/changeset/base/290201

Log:
  Do not FALLTHROUGH for SIOC{ADD,DEL}MULTI
  
  ifmedia_ioctl() returns EINVAL
  
  Differential Revision:	3897
  Submitted by:	aronen@juniper.net
  Reviewed by:	marcel

Modified:
  head/sys/dev/xen/netfront/netfront.c

Modified: head/sys/dev/xen/netfront/netfront.c
==============================================================================
--- head/sys/dev/xen/netfront/netfront.c	Fri Oct 30 17:05:52 2015	(r290200)
+++ head/sys/dev/xen/netfront/netfront.c	Fri Oct 30 17:12:15 2015	(r290201)
@@ -1663,7 +1663,7 @@ xn_ioctl(struct ifnet *ifp, u_long cmd, 
 			error = 0;
 		}
 #endif
-		/* FALLTHROUGH */
+		break;
 	case SIOCSIFMEDIA:
 	case SIOCGIFMEDIA:
 		error = ifmedia_ioctl(ifp, ifr, &sc->sc_media, cmd);



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201510301712.t9UHCFPd096813>