From nobody Mon Mar 18 12:26:10 2024 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TyvGg3NcDz5DdcB; Mon, 18 Mar 2024 12:26:19 +0000 (UTC) (envelope-from mike@karels.net) Received: from mail2.karels.net (mail2.karels.net [3.19.118.201]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "freebsd", Issuer "freebsd" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4TyvGf65Zgz47fH; Mon, 18 Mar 2024 12:26:18 +0000 (UTC) (envelope-from mike@karels.net) Authentication-Results: mx1.freebsd.org; none Received: from mail2.karels.net (localhost [IPv6:0:0:0:0:0:0:0:1]) by mail2.karels.net (8.18.1/8.18.1) with ESMTP id 42ICQBBv054697; Mon, 18 Mar 2024 07:26:11 -0500 (CDT) (envelope-from mike@karels.net) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=karels.net; s=mail2; t=1710764772; bh=ewZYGbxI4QWGlXbwewAilCFxYmXLkdBwORFYqLEWzNw=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=ap7WZBuT+KXXggGCehJWapm7X7UfcU/kFTSJVhf/RurKXnmp+WBJ8yTl/TiymFtv/ ++p8/jmHeGEhduWXotDAOnZkRZ9iok3d4UGEUxWTJ5jc/3U8X0qAnndHEuByEp7tfk Uub65E/PjBb0eqfAvqn1ioGJI1JourWHg41XD1OJotfdDNxAQMmNw731cGiCjkcRP0 P6GdaV1nkWGjwGTfgoYurljaqSfuDt3V6Ot8YSQlzEyQ0UM0Q+qKMVqcqZs71jRJIR GKwE2yY4VWX7e/a75qeCaZiVvVGAQ4O9AHk+6flLT0l6LFzkXMqswnbGpCgkV1QgPA wUQHc309o9frg== Received: from [10.0.2.130] ([73.62.165.147]) by mail2.karels.net with ESMTPSA id jWyrL+My+GWn1QAAs/W3XQ (envelope-from ); Mon, 18 Mar 2024 07:26:11 -0500 From: Mike Karels To: tuexen@freebsd.org Cc: Nuno Teixeira , Drew Gallatin , garyj@gmx.de, current@freebsd.org, net@freebsd.org, Randall Stewart Subject: Re: Request for Testing: TCP RACK Date: Mon, 18 Mar 2024 07:26:10 -0500 X-Mailer: MailMate (1.14r6015) Message-ID: <6047C8EF-B1B0-4286-93FA-AA38F8A18656@karels.net> In-Reply-To: References: <42C327BD-6CE4-43AA-A1AE-3BEC08D623DB@freebsd.org> <486915F0-456B-4B09-A8BC-93BBA79C4CA1@freebsd.org> <20240313080624.6c73908c@ernst.home> <508E3B47-8E1B-469F-97B1-2171A3098888@freebsd.org> <86a5n1i0xg.fsf@ltc.des.dev> <78D1FF09-71A3-4486-B934-D8332F54B237@freebsd.org> <20240316104053.20bef8c2@ernst.home> <20240316115128.33d11f7b@ernst.home> <7367F29A-D52B-4828-B79A-AA2667E81E7D@freebsd.org> <4FF534F6-B35D-4596-8D1E-226AD1347AC8@freebsd.org> <6e795e9c-8de4-4e02-9a96-8fabfaa4e66f@app.fastmail.com> List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:16509, ipnet:3.16.0.0/14, country:US] X-Rspamd-Queue-Id: 4TyvGf65Zgz47fH On 18 Mar 2024, at 7:04, tuexen@freebsd.org wrote: >> On 18. Mar 2024, at 12:42, Nuno Teixeira wrote: >> >> Hello all! >> >> It works just fine! >> System performance is OK. >> Using patch on main-n268841-b0aaf8beb126(-dirty). >> >> --- >> net.inet.tcp.functions_available: >> Stack D Alias PCB= count >> freebsd freebsd 0 >> rack * rack 38 >> --- >> >> It would be so nice that we can have a sysctl tunnable for this patch >> so we could do more tests without recompiling kernel. > Thanks for testing! > > @gallatin: can you come up with a patch that is acceptable for Netflix > and allows to mitigate the performance regression. Ideally, tcphpts could enable this automatically when it starts to be used (enough?), but a sysctl could select auto/on/off. Mike > Best regards > Michael >> >> Thanks all! >> Really happy here :) >> >> Cheers, >> >> Nuno Teixeira escreveu (domingo, 17/03/2024 =C3=A0= (s) 20:26): >>> >>> Hello, >>> >>>> I don't have the full context, but it seems like the complaint is a = performance regression in bonnie++ and perhaps other things when tcp_hpts= is loaded, even when it is not used. Is that correct? >>>> >>>> If so, I suspect its because we drive the tcp_hpts_softclock() routi= ne from userret(), in order to avoid tons of timer interrupts and context= switches. To test this theory, you could apply a patch like: >>> >>> It's affecting overall system performance, bonnie was just a way to >>> get some numbers to compare. >>> >>> Tomorrow I will test patch. >>> >>> Thanks! >>> >>> -- >>> Nuno Teixeira >>> FreeBSD Committer (ports) >> >> >> >> -- = >> Nuno Teixeira >> FreeBSD Committer (ports)