From nobody Thu Jan 22 19:50:47 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4dxs9z4YBCz6QDqF for ; Thu, 22 Jan 2026 19:50:47 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4dxs9z2Bpsz474M for ; Thu, 22 Jan 2026 19:50:47 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1769111447; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0kJiaCEIcGVfA1WCwvf92bx4Qmmj/TOlOWdiaShX4NM=; b=GTCk/MVuxVxcV4gTJfRADt8hkblFg/nlMOt2v/1I7JmwNYtLp7CMfXDlURXbQYivLW2WVb UBvDrE8IbB9TL642H1gIdTLisFCTyIqNRt5n0VX3GEIncADlYcdWjbxM6T1u/xOJ2p0N/W WCrk6nk/PftJYjn1tVIXDDFKk2W+VRGW6SF2ytjv03uvHbrciofqFJ4OFS3UAa1WVksLiZ RnAgzD9TAAJHOmMpv53FAIRiQSMwLa+coyPE5x6JTnXIJJ8DH7LWXc1LVAXsb5F8hyx9sV qoSkaPE4XXW/cqNQEFrQxZOc4aK7zVRQqmx2zBvSvyRH6U2jUupmOk+vxqMp9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1769111447; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=0kJiaCEIcGVfA1WCwvf92bx4Qmmj/TOlOWdiaShX4NM=; b=CTr9eyTSYI6oAlCp8+ySUKyyY9pTlXAPWjSBRBIxF6bstYLchywi+s/gKXfIbc6KWAj5hz xuQtIANuuVdvEX1KpKygdpe73KsDyhszY08hOaYdmI/J64aiA7YmqknQpRKa5cFfkTEsIf 3I+59R9+M+inUxA5QlUJWpSgAsH02wWoI+zPT9DrL9tGnyrB+xgaKJ7zR4YtY/leIy0uJO XDRJd9JlKyF6aJ39UrKjvqeNJyQEf242rrEwHbeHbZntWz7qRvSXr3OFidrYM+NeSlLNSh 5OfDsFHfwp83ySQ4An4pB0Wsd8K3MsjeOqCN2+hoY3srPsT+Owl7QU1AEc4W8Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1769111447; a=rsa-sha256; cv=none; b=cOTQ2I6Bus10gh4qCizVSGWZLRG2mANxUBJuA7AulC0MJbGtW95r/nn90Va2XSlXdgrk8o 51FrA0Y11Aw25TfuY8E6KYOhVDvEXlDctPKBqqpefuNOj83EkVFhb9vsUrYtAcs053LanU Qely0C5LLwY14F0ACD8fDrN3nnY1I+QSubhdFXkt1IAsRvfqHMvSyC2qXnKsvPfYQ0e2A0 PZZIoYDagiHxrbirFhjErGAtAOFyzhwgdi/yiLIJhzn6L2UK1Xo6Dc7CObFcITTE9n+XMH 7MEfG54Ax/5AScB0TJdINXBGf76dIfExDSxn3tD14sXi+7JNCOT+sbnmaxBNhw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4dxs9z1hS1znRP for ; Thu, 22 Jan 2026 19:50:47 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 21b85 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Thu, 22 Jan 2026 19:50:47 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Siva Mahadevan Subject: git: 8352e24d0bc5 - main - tests/ktest_netlink_message_writer: remove INVARIANTS requirement List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: siva X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 8352e24d0bc59f9730980986600bde7d8cdce21d Auto-Submitted: auto-generated Date: Thu, 22 Jan 2026 19:50:47 +0000 Message-Id: <69727f97.21b85.7e8c5cdb@gitrepo.freebsd.org> The branch main has been updated by siva: URL: https://cgit.FreeBSD.org/src/commit/?id=8352e24d0bc59f9730980986600bde7d8cdce21d commit 8352e24d0bc59f9730980986600bde7d8cdce21d Author: Siva Mahadevan AuthorDate: 2026-01-22 19:49:51 +0000 Commit: Siva Mahadevan CommitDate: 2026-01-22 19:49:51 +0000 tests/ktest_netlink_message_writer: remove INVARIANTS requirement INVARIANTS is meant to be used to enable extra sanity checking for internal structures, not enable/disable tests in the freebsd kyua test suite. STABLE branches include a GENERIC kernconf without INVARIANTS, so ktest_netlink_message_writer is broken on such branches: https://ci.freebsd.org/job/FreeBSD-stable-15-amd64-test/253/testReport/sys.netlink.test_netlink_message_writer/py/__test_cases_list__/ Reviewed by: lwhsu, imp Approved by: lwhsu (mentor) Pull Request: https://github.com/freebsd/freebsd-src/pull/1889 MFC after: 3 days Signed-off-by: Siva Mahadevan Sponsored by: The FreeBSD Foundation --- sys/netlink/ktest_netlink_message_writer.c | 5 ----- sys/netlink/ktest_netlink_message_writer.h | 2 +- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/sys/netlink/ktest_netlink_message_writer.c b/sys/netlink/ktest_netlink_message_writer.c index 805f52197f69..0e8b962bbd34 100644 --- a/sys/netlink/ktest_netlink_message_writer.c +++ b/sys/netlink/ktest_netlink_message_writer.c @@ -37,8 +37,6 @@ #define KTEST_CALLER #include -#ifdef INVARIANTS - struct test_nlbuf_attrs { uint32_t size; uint32_t expected_avail; @@ -98,16 +96,13 @@ test_nlbuf_writer_allocation(struct ktest_test_context *ctx) return (0); } -#endif static const struct ktest_test_info tests[] = { -#ifdef INVARIANTS { .name = "test_nlbuf_writer_allocation", .desc = "test different buffer sizes in the netlink writer", .func = &test_nlbuf_writer_allocation, .parse = &test_nlbuf_parser, }, -#endif }; KTEST_MODULE_DECLARE(ktest_netlink_message_writer, tests); diff --git a/sys/netlink/ktest_netlink_message_writer.h b/sys/netlink/ktest_netlink_message_writer.h index 447593e0e700..1abf0d48de95 100644 --- a/sys/netlink/ktest_netlink_message_writer.h +++ b/sys/netlink/ktest_netlink_message_writer.h @@ -28,7 +28,7 @@ #ifndef _NETLINK_KTEST_NETLINK_MESSAGE_WRITER_H_ #define _NETLINK_KTEST_NETLINK_MESSAGE_WRITER_H_ -#if defined(_KERNEL) && defined(INVARIANTS) +#if defined(_KERNEL) bool nlmsg_get_buf_wrapper(struct nl_writer *nw, size_t size, bool waitok);