From nobody Wed Feb 4 22:07:25 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f5vbd5DCfz6QjJS for ; Wed, 04 Feb 2026 22:07:25 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f5vbd4Y58z3Hjv for ; Wed, 04 Feb 2026 22:07:25 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770242845; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BoJDKkvR9NJaYsMU8mGweZGSwfn+5+xzd0MIqLqlzlw=; b=v5GQ2dftw6CPPtWW4MltAtxN3eTlZHN/WLgF1IQOFD6+TCJof+rj0dwIy5QUyvmz4BcA1h LIR0JvTRbhrYyOSmcaiCljI2nFUyBEZFPD+9lO+TtaNsQT4Rpo24PKfBg3pBJfG1kX0LP3 eDPSWm45vn+X8xy2ruxaTRcn075YhcRnVVezmAn5Hi5fZIWxDQjjO6Erw/ex11yxSKcMW+ PuqccJCE7XRGyLiyMWKGO6DA4L9xwLAfYD/BJzJIrjEng+n8WGXMdQO/hl7uFp2+MrFYE0 aUFgwhWqdnaJ+bZ0HNOcm+gLrpihEzTWXCeen1R9WV65l7qMJ3yf4W6UuGNzHw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1770242845; a=rsa-sha256; cv=none; b=oCYDGxg/tsBzKiIOX70n7xY+YcM7k3WYf26UKTxcxPjDCn5p3xHbHlgb7CeZaqtubK67se Am/a5xxSwFEXBRCc1R5VJQVEouJn+kWVLxGhCwtNFGYzOzbCro2mticxbr0chuBhm/AqvE Nw0s55HjHjbYZ8uJe7VnJ0vWZynjigNQrIKCSL6198GL1y3OJHBLvcO2x8fc91C5o81xUr 8XkEfpCEGQfVMqQA4QTsyG+Z3oUY59Go5trr2+XLPsgDfXbV1hOGZyUXFXTdcrm79paXcb ryHL3EdrNX094TAwZZKt4yef7CmX6lfY5Pj7AWHQ7WprNrmTw5e5AF9Ld+cjfw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770242845; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BoJDKkvR9NJaYsMU8mGweZGSwfn+5+xzd0MIqLqlzlw=; b=PW+p8N1gZKAE3gHWLVjRt1w6OQTrmxHFzlaxXd0KSDR1M1MdRjV0xIgtMm9/43XpwpZZDN ufSIJzQrqVpa/kbLyRVxfHNWPF0632FR4rhW30O4okBIpFrjvdkdXObYWCnQ3C1wo+vUxJ 5eWY4oX+ZGfND17yZKhRwEBRYec+lapsJNfpIgVsJyatPwDJiSkALtvJxUN1Stoa73Hs39 vkB2w9q6tUN+DWlN69TX5wGHEeBUpp0/4faAYc6Q3If+Gl6H6PbznP9ek5NOWqOX6QzXKK wtJ2tLw14m7d36Ae3IFSlTrIEON4HUKNaWE8xhrPxHqsfOH/YSYh6+is/K+MYQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4f5vbd460Fz1G95 for ; Wed, 04 Feb 2026 22:07:25 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 19fab by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 04 Feb 2026 22:07:25 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Gleb Smirnoff Subject: git: 5937e1cdc991 - main - bpf: don't clear pointer from descriptor to the tap on descriptor close List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: glebius X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 5937e1cdc99180b4adae2cf20cabd75dd9f45546 Auto-Submitted: auto-generated Date: Wed, 04 Feb 2026 22:07:25 +0000 Message-Id: <6983c31d.19fab.6a4635ed@gitrepo.freebsd.org> The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=5937e1cdc99180b4adae2cf20cabd75dd9f45546 commit 5937e1cdc99180b4adae2cf20cabd75dd9f45546 Author: Gleb Smirnoff AuthorDate: 2026-02-04 22:07:11 +0000 Commit: Gleb Smirnoff CommitDate: 2026-02-04 22:07:11 +0000 bpf: don't clear pointer from descriptor to the tap on descriptor close During packet processing the descriptor is looked up using epoch(9) and it can be accessed after bpf_detachd(). In scenario of descriptor close the tap point is alive (it actually produces packets) and thus the pointer can be legitimately dereferenced. This fixes a race on a bpf(4) device close that would otherwise result in panic. Differential Revision: https://reviews.freebsd.org/D55064 --- sys/net/bpf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/net/bpf.c b/sys/net/bpf.c index 9f0b57728e88..228ac9867bd7 100644 --- a/sys/net/bpf.c +++ b/sys/net/bpf.c @@ -678,8 +678,8 @@ bpf_detachd(struct bpf_d *d, bool detached_ifp) BPFD_LOCK(d); CK_LIST_REMOVE(d, bd_next); writer = (d->bd_writer > 0); - d->bd_bif = NULL; if (detached_ifp) { + d->bd_bif = NULL; /* * Notify descriptor as it's detached, so that any * sleepers wake up and get ENXIO.