From owner-svn-src-all@FreeBSD.ORG  Wed Jun  3 20:01:03 2015
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 6285938D;
 Wed,  3 Jun 2015 20:01:03 +0000 (UTC)
 (envelope-from glebius@FreeBSD.org)
Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "cell.glebius.int.ru", Issuer "cell.glebius.int.ru" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id E22611A23;
 Wed,  3 Jun 2015 20:01:02 +0000 (UTC)
 (envelope-from glebius@FreeBSD.org)
Received: from cell.glebius.int.ru (localhost [127.0.0.1])
 by cell.glebius.int.ru (8.14.9/8.14.9) with ESMTP id t53K105v044978
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Wed, 3 Jun 2015 23:01:00 +0300 (MSK)
 (envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
 by cell.glebius.int.ru (8.14.9/8.14.9/Submit) id t53K10Cc044977;
 Wed, 3 Jun 2015 23:01:00 +0300 (MSK)
 (envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to
 glebius@FreeBSD.org using -f
Date: Wed, 3 Jun 2015 23:01:00 +0300
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Luiz Otavio O Souza <loos@FreeBSD.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: Re: svn commit: r283948 - head/sys/dev/dwc
Message-ID: <20150603200100.GB73119@FreeBSD.org>
References: <201506031448.t53Em4Gn090709@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201506031448.t53Em4Gn090709@svn.freebsd.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Jun 2015 20:01:03 -0000

On Wed, Jun 03, 2015 at 02:48:04PM +0000, Luiz Otavio O Souza wrote:
L> Author: loos
L> Date: Wed Jun  3 14:48:03 2015
L> New Revision: 283948
L> URL: https://svnweb.freebsd.org/changeset/base/283948
L> 
L> Log:
L>   Fix the OACTIVE handling on if_dwc.
L>   
L>   Previously the OACTIVE flag was being set when the tx descriptors are fully
L>   allocated but it wasn't unset anywhere.
L>   
L>   As soon as a packet is transmitted, unset the OACTIVE flag and call start
L>   routine to push any pending packets from the tx queue.
L>   
L>   This closes another race where a full tx queue would jam the tx path (tx
L>   queue is full, new packets cannot be added to queue and dwc_txstart never
L>   gets called).

The only real fix of OACTIVE handling is removing OACTIVE :)

-- 
Totus tuus, Glebius.