From owner-freebsd-ports-bugs@FreeBSD.ORG  Thu Dec  9 03:34:07 2004
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 6F78716A4EA; Thu,  9 Dec 2004 03:34:07 +0000 (GMT)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 476C843D41; Thu,  9 Dec 2004 03:34:07 +0000 (GMT)
	(envelope-from hq@FreeBSD.org)
Received: from freefall.freebsd.org (hq@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.1/8.13.1) with ESMTP id iB93Y7wa060579;
	Thu, 9 Dec 2004 03:34:07 GMT
	(envelope-from hq@freefall.freebsd.org)
Received: (from hq@localhost)
	by freefall.freebsd.org (8.13.1/8.13.1/Submit) id iB93Y75f060575;
	Thu, 9 Dec 2004 03:34:07 GMT
	(envelope-from hq)
Date: Thu, 9 Dec 2004 03:34:07 GMT
From: Herve Quiroz <hq@FreeBSD.org>
Message-Id: <200412090334.iB93Y75f060575@freefall.freebsd.org>
To: whitekid@gmail.com, hq@FreeBSD.org,
	freebsd-ports-bugs@FreeBSD.org, hq@FreeBSD.org
Subject: Re: ports/74882: [New ports] java/httpunit: web test framework
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>,
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>,
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 09 Dec 2004 03:34:07 -0000

Synopsis: [New ports] java/httpunit: web test framework

State-Changed-From-To: open->feedback
State-Changed-By: hq
State-Changed-When: Thu Dec 9 03:17:42 GMT 2004
State-Changed-Why: 
Several remarks:

- The FreeBSD Java community has just made a statement that new ports should
  not have 'java' as their primary category, unless it is the only one (for JDK
  related stuff). So I suggest the following instead:

CATEGORIES= devel java

  The port will end up in 'devel/httpunit' then, which I think is fine, as
  there's already 'devel/apache-ant' and 'devel/maven'

- JDK_VERSION is wrong. It should be JAVA_VERSION if you want to specify a
  particular version of the JDK.

- ${JAVAJARDIR:S,^${PREFIX},${LOCALBASE},} should be replaced with
  ${JAVALIBDIR}

- You could (and should probably) get rid of all documentation entries in
  pkg-plist by using PORTDOCS (which is currently set to 'doc' and that does
  not have any effect as 'doc' is not installed in ${DOCSDIR}):

PORTDOCS= api images manual plans.txt release_notes.txt sslfaq.html todo.txt tutorial

- The same way, you could just remove totally pkg-plist by using:

PLIST_FILES= ${DEPEND_JARS:S,^,%%JAVAJARDIR%%/,} \
             ${JAR_FILES:S,^,%%JAVAJARDIR%%/,}

- There's something strange with the following line in the header:

Date created:                Jun 15 1999

- AFAICT, DISTNAME=${PORTNAME}-${PORTVERSION} by default

- The DATADIRS variable is set but not used



Responsible-Changed-From-To: freebsd-ports-bugs->hq
Responsible-Changed-By: hq
Responsible-Changed-When: Thu Dec 9 03:17:42 GMT 2004
Responsible-Changed-Why: 
I'll handle this.

http://www.freebsd.org/cgi/query-pr.cgi?pr=74882