From owner-cvs-all Thu Dec 13 8:18:11 2001 Delivered-To: cvs-all@freebsd.org Received: from freebie.xs4all.nl (freebie.xs4all.nl [213.84.32.253]) by hub.freebsd.org (Postfix) with ESMTP id 998EE37B416; Thu, 13 Dec 2001 08:18:04 -0800 (PST) Received: (from wkb@localhost) by freebie.xs4all.nl (8.11.6/8.11.6) id fBDGI1G80579; Thu, 13 Dec 2001 17:18:01 +0100 (CET) (envelope-from wkb) Date: Thu, 13 Dec 2001 17:18:01 +0100 From: Wilko Bulte To: Kirk McKusick Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/ufs/ffs ffs_inode.c Message-ID: <20011213171801.A80549@freebie.xs4all.nl> References: <200112130507.fBD57n063530@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <200112130507.fBD57n063530@freefall.freebsd.org>; from mckusick@FreeBSD.ORG on Wed, Dec 12, 2001 at 09:07:49PM -0800 X-OS: FreeBSD 4.4-STABLE X-PGP: finger wilko@freebsd.org Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Wed, Dec 12, 2001 at 09:07:49PM -0800, Kirk McKusick wrote: > mckusick 2001/12/12 21:07:49 PST > > Modified files: > sys/ufs/ffs ffs_inode.c > Log: > When a file is partially truncated, we first check to see if the > new file end will land in the middle of a file hole. Since the last > block of a file must always be allocated, the hole is filled by > allocating a block at that location. If the hole being filled is > a direct block, then the truncation may eventually reduce the > full sized block down to a fragment. When running with soft > updates, it is necessary to FSYNC the file after allocating the > block and before creating the fragment to avoid triggering a > soft updates inconsistency when the block unexpectedly shrinks. > > Found by: Matthew Dillon > MFC after: 1 week FWIW: that is almost exactly on Code Freeze Day. Is this fix critical for 4.5-R ? -- | / o / /_ _ email: wilko@FreeBSD.org |/|/ / / /( (_) Bulte Arnhem, The Netherlands To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message