From owner-freebsd-ports-bugs@FreeBSD.ORG Thu Jul 8 04:58:53 2004 Return-Path: Delivered-To: freebsd-ports-bugs@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 255E116A4CE for ; Thu, 8 Jul 2004 04:58:53 +0000 (GMT) Received: from mta11.adelphia.net (mta11.adelphia.net [68.168.78.205]) by mx1.FreeBSD.org (Postfix) with ESMTP id C9ACA43D55 for ; Thu, 8 Jul 2004 04:58:52 +0000 (GMT) (envelope-from johnmary@adelphia.net) Received: from 68-169-191-150.losaca.adelphia.net ([68.169.191.150]) by mta13.adelphia.netESMTP <20040708045757.NPUO14365.mta13.adelphia.net@68-169-191-150.losaca.adelphia.net>; Thu, 8 Jul 2004 00:57:57 -0400 Received: by 68-169-191-150.losaca.adelphia.net (Postfix, from userid 1001) id 2B7E46167; Wed, 7 Jul 2004 21:57:56 -0700 (PDT) From: John Merryweather Cooper To: Adam Weinberger In-Reply-To: <20040708023132.GM58303@toxic.magnesium.net> References: <200407080050.i680oKvo031955@freefall.freebsd.org> <1089249413.55099.22.camel@68-169-191-150.losaca.adelphia.net> <20040708023132.GM58303@toxic.magnesium.net> Content-Type: text/plain Content-Transfer-Encoding: 7bit Message-Id: <1089262674.55099.25.camel@68-169-191-150.losaca.adelphia.net> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.6 Date: Wed, 07 Jul 2004 21:57:54 -0700 cc: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/68791: [MAINTAINER-UPDATE] Update www/screem to 0.10.2 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Jul 2004 04:58:53 -0000 On Wed, 2004-07-07 at 19:31, Adam Weinberger wrote: > >> (07.07.2004 @ 2116 PST): John Merryweather Cooper said, in 2.7K: << > > > > +# HACK: This allows test builds into a temporary directory, but in the REAL world, > > > > +# gconf would have created this directory. > > > > +pre-install: > > > > + @${MKDIR} ${PREFIX}/etc/gconf/gconf.xml.defaults > > > > > > This is true of many, many ports. I don't think it should be added to > > > port Makefiles. > > > > It is my philosophy that every port should be able to be built/installed > > with something like the following command line: > > > > # make PREFIX=/tmp/screem install > > > > Ports that cannot be built in this manner are, IMO, broken. > > > > Without this hack, www/screem (and all other such ports) cannot be built > > in this manner. The implications are: > > > > 1) such ports cannot be easily tested; > > 2) verifying the contents of the pkg-plist's of such ports is much more > > difficult; > > 3) tools such as plist cannot be used to help generate a draft > > pkg-plist; and > > 4) such ports are only notionally ${PREFIX} safe. > > > > Since this hack does no harm, makes the port truly ${PREFIX} safe, and > > allows better testing, it should stay in. > >> end of "Re: ports/68791: [MAINTAINER-UPDATE] Update www/screem to 0.10.2" from John Merryweather Cooper << > > I completely agree that having non-standard PREFIX installation die is > improper behaviour. Perhaps a better solution would be to add something > like that to bsd.gnome.mk? Maybe overload pre-install like we do for > pre-patch? If such a thing should exist, it could be abstracted to work > for all ports affected as such (at least 50% of GNOME-related ports, in > my experience). > > # Adam > > > -- > Adam Weinberger > adamw@magnesium.net || adamw@FreeBSD.org > adamw@vectors.cx || adamw@gnome.org > http://www.vectors.cx An all-GNOME solution would, of course be best. I would completely endorse overloading pre-install. jmc