From owner-svn-src-head@freebsd.org Wed Aug 24 20:16:41 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 019B8BC5D72; Wed, 24 Aug 2016 20:16:41 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id D16FF18CF; Wed, 24 Aug 2016 20:16:40 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [IPv6:::1]) by freefall.freebsd.org (Postfix) with ESMTP id C48611AA2; Wed, 24 Aug 2016 20:16:40 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id 8F6601AB27; Wed, 24 Aug 2016 20:16:40 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id kxVZQQ3dIeVP; Wed, 24 Aug 2016 20:16:37 +0000 (UTC) Subject: Re: svn commit: r303988 - head/lib/libc/gen DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com 62D341AB1F To: Eric van Gyzen , Ed Schouten References: <201608120703.u7C73whf007189@repo.freebsd.org> <9ae1c2eb-02ad-b8fe-6aff-7e17e955607a@FreeBSD.org> <2632f5f8-d765-3df7-74d7-da878eb4b7a8@FreeBSD.org> <62adcb77-490e-0691-0942-9218c1d55b68@FreeBSD.org> Cc: svn-src-head@freebsd.org, jilles@freebsd.org, svn-src-all@freebsd.org, src-committers , Ed Schouten From: Bryan Drewery Organization: FreeBSD Message-ID: Date: Wed, 24 Aug 2016 13:16:34 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <62adcb77-490e-0691-0942-9218c1d55b68@FreeBSD.org> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="rsxs83XSIVWCo1inh3cIOc2KxDe14cFWb" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Aug 2016 20:16:41 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --rsxs83XSIVWCo1inh3cIOc2KxDe14cFWb Content-Type: multipart/mixed; boundary="LBLMdnBaefR9SQIIAmJBrbMPlngg7Heif" From: Bryan Drewery To: Eric van Gyzen , Ed Schouten Cc: svn-src-head@freebsd.org, jilles@freebsd.org, svn-src-all@freebsd.org, src-committers , Ed Schouten Message-ID: Subject: Re: svn commit: r303988 - head/lib/libc/gen References: <201608120703.u7C73whf007189@repo.freebsd.org> <9ae1c2eb-02ad-b8fe-6aff-7e17e955607a@FreeBSD.org> <2632f5f8-d765-3df7-74d7-da878eb4b7a8@FreeBSD.org> <62adcb77-490e-0691-0942-9218c1d55b68@FreeBSD.org> In-Reply-To: <62adcb77-490e-0691-0942-9218c1d55b68@FreeBSD.org> --LBLMdnBaefR9SQIIAmJBrbMPlngg7Heif Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 8/24/16 1:12 PM, Eric van Gyzen wrote: > On 08/24/2016 15:01, Ed Schouten wrote: >> 2016-08-24 21:53 GMT+02:00 Bryan Drewery : >>> Is it possible to cause the use of these old prototypes to print a >>> warning and note that they are deprecated/unsafe? >> >> That's a good question. In theory, we could annotate these functions >> with __attribute__((__deprecated__)): >> >> https://gcc.gnu.org/onlinedocs/gcc-3.3.4/gcc/Type-Attributes.html >> >> But I'm actually too afraid to use it. In the worst case it may cause >> the compiler to generate a warning even when basename()/dirname() is >> used correctly, as __old_* will still be part of the compiled >> expression. >=20 > Could __warn_references() be used, as libc currently does for gets() an= d > others? >=20 > Eric >=20 /usr/include/stdio.h:extern char *gets (char *__s) __wur __attribute_deprecated__; /usr/include/x86_64-linux-gnu/sys/cdefs.h:# define __attribute_deprecated__ __attribute__ ((__deprecated__)) __wur being warning about unused result. As for actually using it here, I tried adding it onto the _old_dirname/basename prototypes. It produces an error, fine, in the bootstrap build for xinstall it would not error, great. However, for building xinstall on head where it will not use the __old_dirname and will use the new dirname@FBSD_1.5, it _still_ complains about using the __old_dirname() prototype via __generic and errors in the wrong case. --=20 Regards, Bryan Drewery --LBLMdnBaefR9SQIIAmJBrbMPlngg7Heif-- --rsxs83XSIVWCo1inh3cIOc2KxDe14cFWb Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQEcBAEBCgAGBQJXvgCjAAoJEDXXcbtuRpfPB0YH+gI3fhBCQoZnxfwd/DwqI9U4 Q2+uttqgmRndF3zbUresflVjbb3KNprPOWwc/YMgB6L5bpz9E5hctWqYEH/Q7AoL rXiRmtKoGx1A2TNcso8wP2zy5971ZQQJsVHwflDQDnJtFspHnbTAxylLs4U2beAq wVq+ICWWcEG3e8OUPshvulJZCQpJiATt1ytgG1iTmbcyEemakpc3onsDbYoyjlDY FZbhUkEhw0dfNL8esbUc0tBHlLSc4qH9y7AoQdC7ATOKHVpgj64Jufqos3W2HVwe 5zyS5SxbZ1vp4QjM5KwlBAkXbYIVfXGIHwyUSaC/7esaNzfxYyYDG5ikfkfWCHY= =OirR -----END PGP SIGNATURE----- --rsxs83XSIVWCo1inh3cIOc2KxDe14cFWb--