Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 11 Nov 2022 14:56:35 +0100
From:      =?UTF-8?B?VMSzbA==?= Coosemans <tijl@FreeBSD.org>
To:        Gleb Popov <arrowd@freebsd.org>
Cc:        FreeBSD ports list <freebsd-ports@freebsd.org>
Subject:   Re: Temporary variables in make .for loops
Message-ID:  <20221111145635.045da586@FreeBSD.org>
In-Reply-To: <CALH631=xg5-cRPwZs-DXBW0LqycN4%2BrP8w5ziQ-ncqdwq%2BPPMw@mail.gmail.com>
References:  <CALH631=xg5-cRPwZs-DXBW0LqycN4%2BrP8w5ziQ-ncqdwq%2BPPMw@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 11 Nov 2022 15:41:51 +0300 Gleb Popov <arrowd@freebsd.org> wrote:
> Hello fellow porters.
> 
> My variable modifiers are growing and become too incomprehensible, so
> here is the question I wanted to ask long ago:
> 
> How do I make and use a temporary variable in the .for loop?
> 
> This is what I have in Mk/Uses/cabal.mk:
> 
> .  for package in ${_use_cabal}
> _PKG_GROUP=        ${package:C/[\.-]//g}
> 
> MASTER_SITES+=    https://hackage.haskell.org/package/:${package:C/[\.-]//g}
> .  endfor
> 
> I'd like to write ${_PKG_GROUP} instead of repeating that regexp
> incantation, but due to specifics of .for operation it doesn't work.
> Using := with _PKG_GROUP also doesn't fix the problem.
> 
> Now I need to add another regexp substitution to every expression
> inside this loop and it'll become even less readable than before.
> 
> Is there a clean solution to this problem?

You could use a nested .for loop:

.  for package in ${_use_cabal}
.    for pkg_group pkg_norev rev in \
	${package:C/[.-]//g} ${packa...} ${packa...}

You can drop the backslash by the way.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20221111145635.045da586>