From owner-cvs-src@FreeBSD.ORG Fri Feb 3 08:11:00 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id EA4CE16A420; Fri, 3 Feb 2006 08:11:00 +0000 (GMT) (envelope-from Hartmut.Brandt@dlr.de) Received: from smtp-3.dlr.de (smtp-3.dlr.de [195.37.61.187]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2A28043D75; Fri, 3 Feb 2006 08:10:54 +0000 (GMT) (envelope-from Hartmut.Brandt@dlr.de) Received: from beagle.kn.op.dlr.de ([129.247.173.6]) by smtp-3.dlr.de over TLS secured channel with Microsoft SMTPSVC(6.0.3790.211); Fri, 3 Feb 2006 09:10:54 +0100 Date: Fri, 3 Feb 2006 09:11:00 +0100 (CET) From: Harti Brandt X-X-Sender: brandt_h@beagle.kn.op.dlr.de To: Matt Jacob In-Reply-To: <200602022131.k12LVZeg023094@repoman.freebsd.org> Message-ID: <20060203091020.W59587@beagle.kn.op.dlr.de> References: <200602022131.k12LVZeg023094@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-OriginalArrivalTime: 03 Feb 2006 08:10:54.0037 (UTC) FILETIME=[5A846050:01C62899] Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/isp isp_freebsd.c isp_freebsd.h isp_inline.h isp_library.c isp_library.h isp_pci.c ispvar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Harti Brandt List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Feb 2006 08:11:01 -0000 Thanks. Do we need to MFC this to unbreak the RELENG_6 tinderbox? harti On Thu, 2 Feb 2006, Matt Jacob wrote: MJ>mjacob 2006-02-02 21:31:35 UTC MJ> MJ> FreeBSD src repository MJ> MJ> Modified files: MJ> sys/dev/isp isp_freebsd.c isp_freebsd.h isp_pci.c MJ> ispvar.h MJ> Added files: MJ> sys/dev/isp isp_library.c isp_library.h MJ> Removed files: MJ> sys/dev/isp isp_inline.h MJ> Log: MJ> Remove use of inlines and use the functions as a library. MJ> MJ> Larger code space, possibly performance hit, but more portable. MJ> Certainly less questionable use of inlining. MJ> MJ> Suggested by: des MJ> MJ> Revision Changes Path MJ> 1.109 +12 -12 src/sys/dev/isp/isp_freebsd.c MJ> 1.83 +10 -17 src/sys/dev/isp/isp_freebsd.h MJ> 1.34 +0 -1854 src/sys/dev/isp/isp_inline.h (dead) MJ> 1.1 +1710 -0 src/sys/dev/isp/isp_library.c (new) MJ> 1.1 +158 -0 src/sys/dev/isp/isp_library.h (new) MJ> 1.109 +15 -9 src/sys/dev/isp/isp_pci.c MJ> 1.73 +1 -3 src/sys/dev/isp/ispvar.h MJ> MJ> MJ>