From owner-freebsd-wireless@FreeBSD.ORG Wed Jan 7 14:09:02 2015 Return-Path: Delivered-To: wireless@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id DF4F8256 for ; Wed, 7 Jan 2015 14:09:02 +0000 (UTC) Received: from nm27-vm5.access.bullet.mail.gq1.yahoo.com (nm27-vm5.access.bullet.mail.gq1.yahoo.com [216.39.63.145]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A2F30647D8 for ; Wed, 7 Jan 2015 14:09:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=att.net; s=s1024; t=1420639734; bh=hV+jYni58SquCOCR2sFMPus1xJ/3XH/omBU83wL9AsQ=; h=Date:From:To:CC:Subject:References:In-Reply-To:From:Subject; b=5o8CY7dD7OTneFzflCSFcRvrPRkqmTwDtKe+udJs1LURhmGmVUcOQZgYeA+YySxZzQKpbUcdGLLm63L4HP/XrDdZv4dBFwY/UaPY5Q8zNrpOY5tTICvY2JTXcI6ixwf9bUmQ7+OjGZA285ZorCLTIBMTMPcFtzKfuPTPx0+YkLA= DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=att.net; b=P7qQTbEtOtMjpmirupSevHoJ1wObMR15QyOXm0k8ckof9Q1B4wpvNAZIwUW/MJAkjuoR1OiG5Hcyy9nQXcyZQwRehmd1F1YtiDX7WSTIx++zQi/zterRq8zv8pYSD/hRaVT+9KOIkOmbtXmtQa3H0ZO5v140Z2VPMTfffJR2f8I=; Received: from [216.39.60.172] by nm27.access.bullet.mail.gq1.yahoo.com with NNFMP; 07 Jan 2015 14:08:54 -0000 Received: from [98.138.226.240] by tm8.access.bullet.mail.gq1.yahoo.com with NNFMP; 07 Jan 2015 14:08:54 -0000 Received: from [127.0.0.1] by smtp111.sbc.mail.ne1.yahoo.com with NNFMP; 07 Jan 2015 14:08:54 -0000 X-Yahoo-Newman-Id: 556379.65758.bm@smtp111.sbc.mail.ne1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: 13gt_VgVM1kYrYjO0u75s3nXe_u4YqME5Iam4dj2HvWnEqB gJ_t7sW62ahMi5tZJ1QaPNDQhnaL8wDR82Rj6KUJ5uiUJjOTB4vYde9FUkLT 7Ir9lDlHpAKiyMlAVlg_GvvffDzwwrAfr7.4PRY_4PhLleJ5cwsO9PyRCRQH 6WvEZwVHI5HftGmsPqG7aPNaZTnsOtJEuQz7Sa6Wis.ycJJWT4OgxpSOAR1X OrGvjU0cRVunzX5Zv3sHv2u_dON6Vrto7qUIQDQRWnA_sZ2.Xe0JMdrzCmZ8 IAzpaTLaui1b_w1wPgfo1Vf7dF09.AJ2zUJxnI_SRXmi4GlUbKhCjRJO3fw4 bBDtVBbr4Zhw31K0UaRtGTVphkD2kvuP6WC_jFi1CzAuIJCWVXYkw2QV.i2J YwEKplv9kPHz.MAftW4yh7R73BzuQlozE_4LdOOfORulrglDJsf3Jmm.CKv8 9iVzFc7z6wDtGM_XfHZWQwhGSKdQwLuhOcP2jTIP5e7Mknd91xB.WJddOUeq r7rBRHkY9P0i6X5fPHsszmBmyWRfXb5MCZWrk5.yXmkK5Sw-- X-Yahoo-SMTP: OKD1keCswBBTAmAF1s00hLyKW3wE3YfSK0Eazl6b4VZG4LTqJxg- Message-ID: <54AD3DF5.1070905@att.net> Date: Wed, 07 Jan 2015 09:08:53 -0500 From: Anthony Jenkins User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Adrian Chadd Subject: Re: Atheros AR9565 detected, not working References: <433678684.160603.1419257025708.JavaMail.yahoo@jws10658.mail.bf1.yahoo.com> <54987366.6060803@yahoo.com> <5498780B.90704@yahoo.com> <5498944C.4040706@yahoo.com> In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: Anthony Jenkins , "wireless@freebsd.org" X-BeenThere: freebsd-wireless@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "Discussions of 802.11 stack, tools device driver development." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Jan 2015 14:09:03 -0000 Hi Adrian, Just letting you know I haven't died in a shootout with the US FBI or anything, just been working on (and suprisingly fixing) issues with my HP Envy Sleekbook 6 since the holidays. I'll be cleaning up my patches and posting to the wiki this week (hopefully). Also still sitting on that ACPI patch for the RTC CMOS handler. > So, would you mind trying your patch again but only with the bits that > allow the GPIO pins to be enabled? If that works, then I'll commit > that Just to be clear, instead of commenting out the early exits in the GPIO readers/writers for certain GPIO addresses, I should selectively give the AR9565 a pass? ...or do you want me to /just/ comment out the early exits, and revert the added call to ar9300_enable_rf_kill() and see if that works? I don't like those early exit bits anyway... > In parallel I'm going to have to tidy up the rfkill capability > API to correctly set bits - I'll likely expand the field in the driver > and have the pre-AR9300 chipset code error out if an out-of-bounds > gpio value is sent. Excellent! Anything I can help with? We /have/ an rfkill API? ...because I need some way to connect my newly-fixed laptop wifi-enable key to some function to enable/disable the radios. Right now I'm just throwing an event over to devd(8). Thanks, Anthony On 12/23/2014 13:06, Adrian Chadd wrote: > On 22 December 2014 at 14:57, Adrian Chadd wrote: > >> Ok, let me go see what's going on. > I dislike when I say "let me see what's going on" and then I .. see > what's going on. > > So: > > * the ar5212 HAL does the right thing - it checks the rfkill setup in > ar5212Reset() and enables it if required > * it also populates the rfkill data from EEPROM at attach time > * the sysctl code just grabs the rfkill /eeprom field/ and .. well, > that's the API. So I have to see if that's the same for the AR9300 or > not. Grr. > > Well, it kinda is: > > ar9300eep.h:#define EEP_RFSILENT_ENABLED 0x0001 /* bit 0: > enabled/disabled */ > ar9300eep.h:#define EEP_RFSILENT_ENABLED_S 0 /* bit 0: > enabled/disabled */ > ar9300eep.h:#define EEP_RFSILENT_POLARITY 0x0002 /* bit 1: polarity */ > ar9300eep.h:#define EEP_RFSILENT_POLARITY_S 1 /* bit 1: polarity */ > ar9300eep.h:#define EEP_RFSILENT_GPIO_SEL 0x00fc /* bits 2..7: > gpio PIN */ > ar9300eep.h:#define EEP_RFSILENT_GPIO_SEL_S 2 /* bits 2..7: > gpio PIN */ > > .. but on the AR5212: > > ../ah_eeprom_v1.h:#define AR_EEPROM_RFSILENT_GPIO_SEL 0x001c > ../ah_eeprom_v1.h:#define AR_EEPROM_RFSILENT_GPIO_SEL_S 2 > ../ah_eeprom_v1.h:#define AR_EEPROM_RFSILENT_POLARITY 0x0002 > ../ah_eeprom_v1.h:#define AR_EEPROM_RFSILENT_POLARITY_S 1 > ../ah_eeprom_v3.h:#define AR_EEPROM_RFSILENT 0x0f /* RF > Silent/Clock Run Enable */ > ../ah_eeprom_v3.h:#define AR_EEPROM_RFSILENT_GPIO_SEL 0x001c > ../ah_eeprom_v3.h:#define AR_EEPROM_RFSILENT_GPIO_SEL_S 2 > ../ah_eeprom_v3.h:#define AR_EEPROM_RFSILENT_POLARITY 0x0002 > ../ah_eeprom_v3.h:#define AR_EEPROM_RFSILENT_POLARITY_S 1 > > .. so more bits are available on the ar9300. I have to check the > AR5416 too; maybe more bits are also available there. > > Grr! > > * Then, the Ar5212 is doing it in ar5212Reset(), but ar5416Reset() > isn't doing it! So I'm going to have to go and hook that up for the > AR5416, AR9160, AR9280, AR9285, AR9287. Ugh. > > * the ar9300 HAL on -HEAD has this in ar9300_reset(): > > /* Reset ier reference count to disabled */ > // OS_ATOMIC_SET(&ahp->ah_ier_ref_count, 1);C > if (ath_hal_isrfkillenabled(ah)) { > ar9300_enable_rf_kill(ah); > } > > .. so it should be enabling it at reset. We shouldn't need to enable > it during ar9300_attach() as the first reset will set it up. > > * The AR5212 HAL enables rfkill interrupts, but the AR9300 doesn't. > Apparently there are .. issues. I don't know what they are. So maybe > we should use polling on that particular GPIO pin to provide rfkill > feedback to the driver and eventually the network stack. > > So, would you mind trying your patch again but only with the bits that > allow the GPIO pins to be enabled? If that works, then I'll commit > that. In parallel I'm going to have to tidy up the rfkill capability > API to correctly set bits - I'll likely expand the field in the driver > and have the pre-AR9300 chipset code error out if an out-of-bounds > gpio value is sent. > > Thanks! > > > > -adrian > _______________________________________________ > freebsd-wireless@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-wireless > To unsubscribe, send any mail to "freebsd-wireless-unsubscribe@freebsd.org" >