From owner-svn-src-head@FreeBSD.ORG Sat Sep 25 07:44:01 2010 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0BE4F106566B; Sat, 25 Sep 2010 07:44:01 +0000 (UTC) (envelope-from prvs=1877da73e7=brian@FreeBSD.org) Received: from idcmail-mo1so.shaw.ca (idcmail-mo1so.shaw.ca [24.71.223.10]) by mx1.freebsd.org (Postfix) with ESMTP id B9DE78FC12; Sat, 25 Sep 2010 07:44:00 +0000 (UTC) Received: from pd3ml2so-ssvc.prod.shaw.ca ([10.0.141.138]) by pd3mo1so-svcs.prod.shaw.ca with ESMTP; 25 Sep 2010 01:28:59 -0600 X-Cloudmark-SP-Filtered: true X-Cloudmark-SP-Result: v=1.1 cv=p1E0FbcuapThhG57xomuiJdXW/Q5N45ug4AOcQEGw+Q= c=1 sm=1 a=9fUDse7kmeoA:10 a=BLceEmwcHowA:10 a=MJPcHhXccCG8eBs0us8XwA==:17 a=2rIISSrIAAAA:8 a=6I5d2MoRAAAA:8 a=pGLkceISAAAA:8 a=tZ5SSJdqAAAA:8 a=MMwg4So0AAAA:8 a=Is3w3vBinDowOhLId8IA:9 a=YJJrZ7KLX9omRmu6FYf1f5WgLScA:4 a=CjuIK1q_8ugA:10 a=uLAUHSNMqMQA:10 a=SV7veod9ZcQA:10 a=MSl-tDqOz04A:10 a=WJ3hkfHDukgA:10 a=mSPrdAm9YTB95ttd-U4A:9 a=SWCM_PHe09QMmdD_lPsUWNtu_lYA:4 a=HpAAvcLHHh0Zw7uRqdWCyQ==:117 Received: from unknown (HELO store.lan.Awfulhak.org) ([70.79.162.198]) by pd3ml2so-dmz.prod.shaw.ca with ESMTP; 25 Sep 2010 01:28:59 -0600 Received: from store.lan.Awfulhak.org (localhost.localdomain [127.0.0.1]) by localhost (Email Security Appliance) with SMTP id C2D45C433C1_C9DA4BAB; Sat, 25 Sep 2010 07:28:58 +0000 (GMT) Received: from gw.Awfulhak.org (gw.lan.Awfulhak.org [172.16.0.1]) by store.lan.Awfulhak.org (Sophos Email Appliance) with ESMTP id 631A7C460FB_C9DA4B7F; Sat, 25 Sep 2010 07:28:55 +0000 (GMT) Received: from dev.lan.Awfulhak.org (brian@dev.lan.Awfulhak.org [172.16.0.5]) by gw.Awfulhak.org (8.14.4/8.14.4) with ESMTP id o8P7Ss0a006044; Sat, 25 Sep 2010 00:28:55 -0700 (PDT) (envelope-from brian@FreeBSD.org) Date: Sat, 25 Sep 2010 00:28:45 -0700 From: Brian Somers To: Kirk McKusick Message-ID: <20100925002845.652e8bd0@dev.lan.Awfulhak.org> In-Reply-To: <201009241920.o8OJKPXk023192@chez.mckusick.com> References: <4C92DC2E.2020602@FreeBSD.org> <201009241920.o8OJKPXk023192@chez.mckusick.com> X-Mailer: Claws Mail 3.7.6 (GTK+ 2.20.1; i386-portbld-freebsd9.0) Mime-Version: 1.0 Content-Type: multipart/signed; micalg=PGP-SHA1; boundary="Sig_/Iiks/N/my8MI5m6+Ti3WsdW"; protocol="application/pgp-signature" Cc: "Carlos A. M. dos Santos" , svn-src-head@FreeBSD.org, Doug Barton Subject: Re: svn commit: r212617 - head/sys/ufs/ffs X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Sep 2010 07:44:01 -0000 --Sig_/Iiks/N/my8MI5m6+Ti3WsdW Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Fri, 24 Sep 2010 12:20:25 -0700 Kirk McKusick wr= ote: > > Date: Thu, 16 Sep 2010 20:10:38 -0700 > > From: Doug Barton > > To: "Carlos A. M. dos Santos" > > CC: Brian Somers , Kirk McKusick , > > svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, > > src-committers@FreeBSD.org > > Subject: Re: svn commit: r212617 - head/sys/ufs/ffs > >=20 > > On 9/16/2010 7:29 PM, Carlos A. M. dos Santos wrote: > > > On Thu, Sep 16, 2010 at 5:44 AM, Brian Somers wro= te: > > >> If INVARIANTS is not defined, the above i++ will not happen. > > > > > > Which does not cause any harm, since "i" is a local variable, not used > > > anywhere else in the function. A picky compiler would complain, > > > however, that the variable is never read. > >=20 > > If 'i' is only ever used in the INVARIANTS case then it should be=20 > > appropriately wrapped everywhere it appears. While the _current_=20 > > situation may be harmless, in the future lack of an appropriate=20 > > indication of its use may cause a problem. This isn't just a pedantic=20 > > concern, we had a case like this that broke the build just recently. > >=20 > >=20 > > Doug > >=20 > > --=20 > >=20 > > ... and that's just a little bit of history repeating. > > -- Propellerheads > >=20 > > Improve the effectiveness of your Internet presence with > > a domain name makeover! http://SupersetSolutions.com/ >=20 > What is the appropriate ifdef for a variable used only inside a KASSERT? >=20 > Kirk McKusick I'd guess '#ifdef INVARIANTS' (from looking at systm.h). --=20 Brian Somers Don't _EVER_ lose your sense of humour ! --Sig_/Iiks/N/my8MI5m6+Ti3WsdW Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (FreeBSD) iQCVAwUBTJ2ktQ7tvOdmanQhAQK0PQP8DSZ9fpAPtgGg5SSIDZHZXrnXecCosz2v IeqT/p0YlO2XzMO8Vw5ClxMxXg4s0w3DjQSGAm9EFMN9f+79uQavVsLWloHJ6sIV 0IkR35NViUBcbZ/4gPx0mbzk+sDRUqIikEDwUyQu08rb06DYqwiVwS8b4TwjeJdx kgFMU8TEQOA= =utIt -----END PGP SIGNATURE----- --Sig_/Iiks/N/my8MI5m6+Ti3WsdW--