From owner-svn-src-head@FreeBSD.ORG Sat Oct 16 08:12:41 2010 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 837661065670; Sat, 16 Oct 2010 08:12:41 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from mail.zoral.com.ua (mx0.zoral.com.ua [91.193.166.200]) by mx1.freebsd.org (Postfix) with ESMTP id F100C8FC12; Sat, 16 Oct 2010 08:12:40 +0000 (UTC) Received: from deviant.kiev.zoral.com.ua (root@deviant.kiev.zoral.com.ua [10.1.1.148]) by mail.zoral.com.ua (8.14.2/8.14.2) with ESMTP id o9G8CbrB060709 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 16 Oct 2010 11:12:37 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: from deviant.kiev.zoral.com.ua (kostik@localhost [127.0.0.1]) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4) with ESMTP id o9G8CbiQ026150; Sat, 16 Oct 2010 11:12:37 +0300 (EEST) (envelope-from kostikbel@gmail.com) Received: (from kostik@localhost) by deviant.kiev.zoral.com.ua (8.14.4/8.14.4/Submit) id o9G8Cbqw026149; Sat, 16 Oct 2010 11:12:37 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: deviant.kiev.zoral.com.ua: kostik set sender to kostikbel@gmail.com using -f Date: Sat, 16 Oct 2010 11:12:37 +0300 From: Kostik Belousov To: Hans Petter Selasky Message-ID: <20101016081237.GR2392@deviant.kiev.zoral.com.ua> References: <201010142038.o9EKcImV036360@svn.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="jGE3xONbfNfY0RQX" Content-Disposition: inline In-Reply-To: <201010142038.o9EKcImV036360@svn.freebsd.org> User-Agent: Mutt/1.4.2.3i X-Virus-Scanned: clamav-milter 0.95.2 at skuns.kiev.zoral.com.ua X-Virus-Status: Clean X-Spam-Status: No, score=-3.4 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00, DNS_FROM_OPENWHOIS autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on skuns.kiev.zoral.com.ua Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r213852 - in head: lib/libusb sys/dev/usb X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Oct 2010 08:12:41 -0000 --jGE3xONbfNfY0RQX Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Oct 14, 2010 at 08:38:18PM +0000, Hans Petter Selasky wrote: > Author: hselasky > Date: Thu Oct 14 20:38:18 2010 > New Revision: 213852 > URL: http://svn.freebsd.org/changeset/base/213852 >=20 > Log: > - Add support for LibUSB in 32-bit compatibility mode. > =20 > Approved by: thompsa (mentor) >=20 > Modified: > head/lib/libusb/Makefile > head/lib/libusb/libusb20.c > head/lib/libusb/libusb20_int.h > head/lib/libusb/libusb20_ugen20.c > head/sys/dev/usb/usb_ioctl.h >=20 > Modified: head/lib/libusb/Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/lib/libusb/Makefile Thu Oct 14 20:31:07 2010 (r213851) > +++ head/lib/libusb/Makefile Thu Oct 14 20:38:18 2010 (r213852) > @@ -30,5 +30,9 @@ SRCS+=3D libusb10.c > SRCS+=3D libusb10_desc.c > SRCS+=3D libusb10_io.c > =20 > +.if defined(COMPAT_32BIT) > +CFLAGS+=3D -DCOMPAT_32BIT > +.endif > + > .include The support is provided in a way that contradicts the established practice of doing 32-bit compat. Very nice that the support is provided, thank you for care about it. But, can it be changed so that the kernel emulates 32-bit ABI instead of library conforming to the kernel ABI ? For COMPAT32, we aim in making the system where 32bit binaries and libraries just work on the 64bit host. Your change does not allow to take 32bit host into jail and run it on 64bit kernel, as example. Please see numerous examples of ioctl translations under #ifdef COMPAT_FREEBSD32 on how it is done. --jGE3xONbfNfY0RQX Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (FreeBSD) iEYEARECAAYFAky5XnQACgkQC3+MBN1Mb4i8fwCeLIBdtrj7uuq95LBmLD8NJDVC cFAAnRFvYgdJHwSHj4YsGdYtSjLA33lj =OQhf -----END PGP SIGNATURE----- --jGE3xONbfNfY0RQX--