From owner-cvs-all@FreeBSD.ORG  Thu Sep 11 07:55:12 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 6A74916A4C0; Thu, 11 Sep 2003 07:55:12 -0700 (PDT)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id BFC2643FE0; Thu, 11 Sep 2003 07:55:11 -0700 (PDT)
	(envelope-from mux@freebsd.org)
Received: by elvis.mu.org (Postfix, from userid 1920)
	id 7BDC52ED413; Thu, 11 Sep 2003 07:55:10 -0700 (PDT)
Date: Thu, 11 Sep 2003 16:55:10 +0200
From: Maxime Henrion <mux@freebsd.org>
To: Tom Rhodes <trhodes@FreeBSD.org>
Message-ID: <20030911145510.GB83361@elvis.mu.org>
References: <200309102055.h8AKtA7N027631@repoman.freebsd.org>
	<20030911062400.GA83361@elvis.mu.org>
	<20030911000107.B38429@12-234-22-23.pyvrag.nggov.pbz>
	<20030911093434.18760596.trhodes@FreeBSD.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20030911093434.18760596.trhodes@FreeBSD.org>
User-Agent: Mutt/1.4.1i
cc: cvs-src@FreeBSD.org
cc: Doug Barton <DougB@FreeBSD.org>
cc: cvs-all@FreeBSD.org
cc: src-committers@FreeBSD.org
Subject: Re: cvs commit: src/usr.sbin/sysinstall config.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 11 Sep 2003 14:55:12 -0000

Tom Rhodes wrote:
> On Thu, 11 Sep 2003 00:06:16 -0700 (PDT)
> Doug Barton <DougB@freebsd.org> wrote:
> 
> > On Thu, 11 Sep 2003, Maxime Henrion wrote:
> > 
> > > Tom Rhodes wrote:
> > > > trhodes     2003/09/10 13:55:10 PDT
> > > >
> > > >   FreeBSD src repository
> > > >
> > > >   Modified files:
> > > >     usr.sbin/sysinstall  config.c
> > > >   Log:
> > > >   With the exim port upgrade, modify sysinstall(8):
> > > >
> > > >   - Add 'enable_exim="YES"' to rc.conf(5)
> > > [...]
> > >
> > > All other rc.conf(5) options that enable services are of the form
> > > <service>_enable.  Why the difference here?
> > 
> > Yeah, this is evil and should be changed. There is not guarantee that
> > this won't totally break someday.
> 
> 
> Quoting Simon since he already answered this:
> 
> It is actually not an issue, since it was just a typo in Tom's commit
> message, not the actual code.  The actual code is :
> 
> --- src/usr.sbin/sysinstall/config.c	2003/08/03 05:55:21	1.212
> +++ src/usr.sbin/sysinstall/config.c	2003/09/10 20:55:09	1.213
> [CUT]
> +    variable_set2("exim_enable", "YES", 1);
> 
> 
> Is there still a problem Doug, Maxime?  I can do a forced commit,
> or when I commit the change being discussed with Ceri I could make
> a comment about the previous revision.

No problems at all.  I should probably have checked in the code before
sending this e-mail, and I actually did, but I read wrong - probably
because it was early in the morning :-).  It might be a good idea to do
a forced commit, though I don't think it's really needed for such a
small typo.

Thanks,
Maxime