From owner-freebsd-python@FreeBSD.ORG  Thu May 15 05:31:46 2014
Return-Path: <owner-freebsd-python@FreeBSD.ORG>
Delivered-To: python@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 42C7DFD6
 for <python@FreeBSD.org>; Thu, 15 May 2014 05:31:46 +0000 (UTC)
Received: from smtprelay02.ispgateway.de (smtprelay02.ispgateway.de
 [80.67.31.29])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 0123B2309
 for <python@FreeBSD.org>; Thu, 15 May 2014 05:31:45 +0000 (UTC)
Received: from [89.182.139.9] (helo=localhost)
 by smtprelay02.ispgateway.de with esmtpsa (TLSv1:AES256-SHA:256)
 (Exim 4.68) (envelope-from <mva@FreeBSD.org>) id 1WkoGW-00041M-G1
 for python@FreeBSD.org; Thu, 15 May 2014 07:31:36 +0200
Date: Thu, 15 May 2014 07:31:40 +0200
From: Marcus von Appen <mva@FreeBSD.org>
To: python@FreeBSD.org
Subject: Re: Wrong python_CMD in shebangfix?
Message-ID: <20140515053140.GA920@medusa.sysfault.org>
Reply-To: Marcus von Appen <mva@FreeBSD.org>
Mail-Followup-To: python@FreeBSD.org
References: <0AE311F0-87F8-4376-8E24-742C6C54F564@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature"; boundary="KsGdsel6WgEHnImy"
Content-Disposition: inline
In-Reply-To: <0AE311F0-87F8-4376-8E24-742C6C54F564@gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-Df-Sender: MTEyNTc0Mg==
X-BeenThere: freebsd-python@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: FreeBSD-specific Python issues <freebsd-python.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-python>,
 <mailto:freebsd-python-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-python/>
List-Post: <mailto:freebsd-python@freebsd.org>
List-Help: <mailto:freebsd-python-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-python>,
 <mailto:freebsd-python-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 15 May 2014 05:31:46 -0000


--KsGdsel6WgEHnImy
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On, Wed May 14, 2014, Dmitry Sivachenko wrote:

> Hello!
>
> Imagine that I have python-2 as default version, so that /usr/local/bin/python points to python2.7
> And I have a port which USE_PYTHON=3 and USES=shebangfix.
>
> It will "fix" python path as "/usr/local/bin/python" which is wrong (it should point to python3).
>

The path is not *wrong*. lang/python installs /usr/local/bin/python.

> I propose the following patch:
> --- shebangfix.mk.orig  2014-03-15 14:31:54.000000000 +0400
> +++ shebangfix.mk       2014-05-14 21:08:37.000000000 +0400
> @@ -38,7 +38,7 @@
>  php_OLD_CMD?=  /usr/bin/php
>  php_CMD?=      ${LOCALBASE}/bin/php
>  python_OLD_CMD?=       /usr/bin/python
> -python_CMD?=   ${LOCALBASE}/bin/python
> +python_CMD?=   ${PYTHON_CMD}
>  ruby_OLD_CMD?= /usr/bin/ruby
>  ruby_CMD?=     ${LOCALBASE}/bin/ruby
>  tcl_OLD_CMD?=  /usr/bin/tclsh
>
>
> What do you think?

Using ${PYTHON_CMD} would save maintainers overriding python_CMD again and
again for many ports.


Cheers
Marcus
--KsGdsel6WgEHnImy
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (FreeBSD)

iEYEARECAAYFAlN0UTsACgkQi68/ErJnpkeoNwCg1C0g7J8OuQpr5R8T+u2ElEqB
cGsAn2t3cdXoc9TckeTK33OVOAzes7sN
=FOMS
-----END PGP SIGNATURE-----

--KsGdsel6WgEHnImy--