Date: Thu, 15 May 2014 07:31:40 +0200 From: Marcus von Appen <mva@FreeBSD.org> To: python@FreeBSD.org Subject: Re: Wrong python_CMD in shebangfix? Message-ID: <20140515053140.GA920@medusa.sysfault.org> In-Reply-To: <0AE311F0-87F8-4376-8E24-742C6C54F564@gmail.com> References: <0AE311F0-87F8-4376-8E24-742C6C54F564@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--KsGdsel6WgEHnImy
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
On, Wed May 14, 2014, Dmitry Sivachenko wrote:
> Hello!
>
> Imagine that I have python-2 as default version, so that /usr/local/bin/python points to python2.7
> And I have a port which USE_PYTHON=3 and USES=shebangfix.
>
> It will "fix" python path as "/usr/local/bin/python" which is wrong (it should point to python3).
>
The path is not *wrong*. lang/python installs /usr/local/bin/python.
> I propose the following patch:
> --- shebangfix.mk.orig 2014-03-15 14:31:54.000000000 +0400
> +++ shebangfix.mk 2014-05-14 21:08:37.000000000 +0400
> @@ -38,7 +38,7 @@
> php_OLD_CMD?= /usr/bin/php
> php_CMD?= ${LOCALBASE}/bin/php
> python_OLD_CMD?= /usr/bin/python
> -python_CMD?= ${LOCALBASE}/bin/python
> +python_CMD?= ${PYTHON_CMD}
> ruby_OLD_CMD?= /usr/bin/ruby
> ruby_CMD?= ${LOCALBASE}/bin/ruby
> tcl_OLD_CMD?= /usr/bin/tclsh
>
>
> What do you think?
Using ${PYTHON_CMD} would save maintainers overriding python_CMD again and
again for many ports.
Cheers
Marcus
--KsGdsel6WgEHnImy
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (FreeBSD)
iEYEARECAAYFAlN0UTsACgkQi68/ErJnpkeoNwCg1C0g7J8OuQpr5R8T+u2ElEqB
cGsAn2t3cdXoc9TckeTK33OVOAzes7sN
=FOMS
-----END PGP SIGNATURE-----
--KsGdsel6WgEHnImy--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140515053140.GA920>