From owner-freebsd-current@FreeBSD.ORG Wed May 7 19:02:50 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 193E137B401; Wed, 7 May 2003 19:02:50 -0700 (PDT) Received: from onion.ish.org (onion.ish.org [219.118.161.2]) by mx1.FreeBSD.org (Postfix) with ESMTP id DD79B43FA3; Wed, 7 May 2003 19:02:46 -0700 (PDT) (envelope-from ishizuka@ish.org) Received: from localhost (ishizuka@localhost [IPv6:::1]) h4822jaO013004; Thu, 8 May 2003 11:02:45 +0900 (JST) (envelope-from ishizuka@ish.org) Date: Thu, 08 May 2003 11:02:45 +0900 (JST) Message-Id: <20030508.110245.41637345.ishizuka@ish.org> To: jhb@FreeBSD.org From: Masachika ISHIZUKA In-Reply-To: References: X-PGP-Fingerprint20: 276D 697A C2CB 1580 C683 8F18 DA98 1A4A 50D2 C4CB X-PGP-Fingerprint16: C6 DE 46 24 D7 9F 22 EB 79 E2 90 AB 1B 9A 35 2E X-PGP-Public-Key: http://www.ish.org/pgp-public-key.txt X-URL: http://www.ish.org/ X-Mailer: Mew version 3.2 on Emacs 21.2 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit cc: current@FreeBSD.org cc: sos@FreeBSD.org Subject: Re: panic: mutex Giant not owned at /usr/src/sys/kern/kern_exit.cwhen ata RAID1 rebuild has completed X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 May 2003 02:02:50 -0000 > On 07-May-2003 John Baldwin wrote: >> On 07-May-2003 Soeren Schmidt wrote: >>> It seems Masachika ISHIZUKA wrote: >>>> I installed 5.1-BETA-20030507-JPSNAP from current.freebsd.org. >>>> I did 'atacontrol rebuild 0' for ata raid ar0 for non-real raid >>>> ata controller (ICH4 in 845GE) with GENERIC kernel and panic when >>>> the RAID1 mirror rebuilding had just completed as follows. >>>> panic: mutex Giant not owned at /usr/src/sys/kern/kern_exit.c: 122 >>> I know of the problem, but I havn't found a good way to fix it yet. >> >> Index: ata-raid.c >> =================================================================== >> RCS file: /usr/cvs/src/sys/dev/ata/ata-raid.c,v >> retrieving revision 1.64 >> diff -u -r1.64 ata-raid.c >> --- ata-raid.c 4 May 2003 16:17:54 -0000 1.64 >> +++ ata-raid.c 5 May 2003 18:15:35 -0000 >> @@ -969,6 +969,7 @@ >> int disk, s, count = 0, error = 0; >> caddr_t buffer; >> >> + mtx_lock(&Giant); > > Ishizuka-san, can you test this patch? Hi, John-san. Thank you for patch. It can be done rebuilding the RAID1 array without panic on 5.1-BETA-20030507-JPSNAP with this patch. -- ishizuka@ish.org